Hi,
On Tue, May 29, 2018 at 1:05 PM, Jason Franklin
<[email protected]> wrote:
> Yegappan,
>
> Attached is the updated patch. To confirm, I...
>
> * merged qf_view_result() and qf_view_result_split()
> * used vim_snprintf(); I believe I used it properly
> * I used the X... functions to merge the test code
>
> Let me know what you think!
>
Thanks for incorporating the feedback. Few more suggestions on the new patch:
1. The location list may not be present always. So the return value of
GET_LOC_LIST()
should be checked against NULL.
2. The Vim source code convention is not to check against TRUE for functions
returning a boolean. Can you change
if (bt_quickfix(curbuf) == TRUE)
to
if (bt_quickfix(curbuf))
Same comment applies for the "if (split == TRUE)" statement.
3. Is it possible to combine the two vim_snprintf() calls into one with a check
for "split"?
Regards,
Yegappan
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
