Hi,
2019/6/7 Fri 15:12:59 UTC+9 Christian Brabandt wrote:
> On Do, 06 Jun 2019, Ken Takata wrote:
>
> > Or, should we also mark gettext v0.19 to v0.19.6 as broken?
>
> I believe, when I tried to git bisect the issue yesterday, the first bad
> commit was around 0.19.3
>
> But I don't think it matters much, Ubuntu 14.04 has version 0.18.3 and
> is already end-of-life for standard support. That leaves us with Ubuntu
> 16.04 which is at version 0.19.7 However the version might look like
> this for non-tagged releases: 0.19.7-<sha_hash>
Even it is a non-tagged version, `msgfmt --version` on Ubuntu 16.04 returns
0.19.7.
> So I would just check for 0.19.7 (without '$')
So I think we can keep '$'.
Checking 0.19.3 to 0.19.6 might be not so useful, but checking them doesn't
have any penalty, I think.
--- a/src/configure.ac
+++ b/src/configure.ac
@@ -4302,8 +4302,13 @@ if test "$enable_nls" = "yes"; then
AC_MSG_CHECKING([if msgfmt supports --desktop])
MSGFMT_DESKTOP=
if "$MSGFMT" --help | grep -e '--desktop' >/dev/null; then
- AC_MSG_RESULT([yes])
- MSGFMT_DESKTOP="gvim.desktop vim.desktop"
+ if "$MSGFMT" --version | grep '0.19.[[3-7]]$' >/dev/null; then
+ dnl GNU gettext 0.19.7's --desktop is broken.
+ AC_MSG_RESULT([broken])
+ else
+ AC_MSG_RESULT([yes])
+ MSGFMT_DESKTOP="gvim.desktop vim.desktop"
+ fi
else
AC_MSG_RESULT([no])
fi
Regards,
Ken Takata
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/vim_dev/7055aa5c-b100-47e7-aa61-5e44898a6fbf%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
