Ken Takata wrote:
> 2019/6/7 Fri 15:12:59 UTC+9 Christian Brabandt wrote:
> > On Do, 06 Jun 2019, Ken Takata wrote:
> >
> > > Or, should we also mark gettext v0.19 to v0.19.6 as broken?
> >
> > I believe, when I tried to git bisect the issue yesterday, the first bad
> > commit was around 0.19.3
> >
> > But I don't think it matters much, Ubuntu 14.04 has version 0.18.3 and
> > is already end-of-life for standard support. That leaves us with Ubuntu
> > 16.04 which is at version 0.19.7 However the version might look like
> > this for non-tagged releases: 0.19.7-<sha_hash>
>
> Even it is a non-tagged version, `msgfmt --version` on Ubuntu 16.04 returns
> 0.19.7.
>
> > So I would just check for 0.19.7 (without '$')
>
> So I think we can keep '$'.
> Checking 0.19.3 to 0.19.6 might be not so useful, but checking them doesn't
> have any penalty, I think.
>
> --- a/src/configure.ac
> +++ b/src/configure.ac
> @@ -4302,8 +4302,13 @@ if test "$enable_nls" = "yes"; then
> AC_MSG_CHECKING([if msgfmt supports --desktop])
> MSGFMT_DESKTOP=
> if "$MSGFMT" --help | grep -e '--desktop' >/dev/null; then
> - AC_MSG_RESULT([yes])
> - MSGFMT_DESKTOP="gvim.desktop vim.desktop"
> + if "$MSGFMT" --version | grep '0.19.[[3-7]]$' >/dev/null; then
> + dnl GNU gettext 0.19.7's --desktop is broken.
> + AC_MSG_RESULT([broken])
> + else
> + AC_MSG_RESULT([yes])
> + MSGFMT_DESKTOP="gvim.desktop vim.desktop"
> + fi
> else
> AC_MSG_RESULT([no])
> fi
Thanks. This looks like the best solution. Let me include it and we
can see if this fixed it for everybody.
--
hundred-and-one symptoms of being an internet addict:
111. You and your friends get together regularly on IRC, even though
all of you live in the same city.
/// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/vim_dev/201906071844.x57Iiw2w028875%40masaka.moolenaar.net.
For more options, visit https://groups.google.com/d/optout.
