Hi, On Sat, Jun 29, 2019 at 6:34 AM Yegappan Lakshmanan <[email protected]> wrote: > > Hi Bram, > > On Sat, Jun 29, 2019 at 5:57 AM Bram Moolenaar > <[email protected]> wrote: > > > > > > > > Thinking about this some more, we should modify the existing > > > > sign_place() function to always accept a List argument > > > > > > Just to say, I don't have any strong feelings either way. I'll defer > > > to those with more experience of the Vim API and how changes are made. > > > > The current sign_place() function is basically mimicking ":sign place". > > One of the quirks is that it takes a file name, not a buffer number. > > > > The sign_place() function accepts either a buffer name or a buffer > number. The {expr} argument to sign_place() is same as the {expr} > argument to bufname(). > > > > > It also has an optional {id}, where zero means it's not passed in. > > > > Yes. Converting sign_place() to accept a List of dicts will make this > simpler. > > > > > Adding a new function that takes a list of dictionaries could be a good > > alternative. We then do need to validate the entries to check if the > > required keys are included. It will then be possible to either pass a > > buffer number or a file name. > > > > I have the changes for this ready to go (including the check for existence > of the required keys). I will merge my local changes with the recent > changes to sign.c/evalfunc.c and create a pull request. >
I have created PR #4602 (https://github.com/vim/vim/pull/4602) for this. I have simplified the sign_place(), sign_unplace() and sign_getplaced() functions. Took some time to make these changes as the sign tests heavily use these functions. Note that this change is not backward compatible. - Yegappan -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/CAAW7x7%3DrJ22qEqXTEEipVbZhr7TLuMumeo9x21h9s_GbR1eLug%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
