Yegappan wrote:
> On Mon, Jul 1, 2019 at 1:38 PM Bram Moolenaar <[email protected]> wrote: > > > > > > > > I have created PR #4602 (https://github.com/vim/vim/pull/4602) for this. > > > I have simplified the sign_place(), sign_unplace() and sign_getplaced() > > > functions. Took some time to make these changes as the sign tests heavily > > > use these functions. Note that this change is not backward compatible. > > > > The sign functions were added more than half a year ago. I don't think > > a change that is not backward compatible will be appreciated. > > > > I think for sign_define() we can support both the old arguments and a > > list argument. for sign_getplaced() we don't need changes. For > > place/unplace add a new "list" function: > > > > sign_define({name} [, {dict}]) > > sign_define({list}) > > > > sign_getplaced([{expr} [, {dict}]]) > > > > sign_place({id}, {group}, {name}, {expr} [, {dict}]) > > sign_placelist({list}) > > > > sign_unplace({group} [, {dict}]) > > sign_unplacelist({list}) > > > > Does that sound reasonable? > > > > I have created PR #4636 that implements the above functions. > > https://github.com/vim/vim/pull/4636 Thanks! It looks good. I'll wait a couple of days to give others a chance to comment. -- ARTHUR: Shut up! Will you shut up! DENNIS: Ah, now we see the violence inherent in the system. ARTHUR: Shut up! DENNIS: Oh! Come and see the violence inherent in the system! HELP! HELP! I'm being repressed! The Quest for the Holy Grail (Monty Python) /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\ /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org /// \\\ help me help AIDS victims -- http://ICCF-Holland.org /// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/201907091953.x69JrXfN020894%40masaka.moolenaar.net. For more options, visit https://groups.google.com/d/optout.
