Felipe Contreras wrote:
> Clearly the code meant to check for SHELL_SILENT in order to send to > /dev/null, not SHELL_EXPAND. > > This works because all the callers of get_cmd_output that use > SHELL_SILENT also use SHELL_EXPAND. > > This has been there since Vim 5.0. I don't think the value should be changed. Unless you can show a situation where the wrong thing happens. There is one call where only SHELL_EXPAND is used in get_cmd_output(). Thus applying the change does have an effect. It's not so easy to see how though. The naming is confusing. It looks like SHELL_EXPAND is used whenever the output of a non-interactive shell command is obtained, where we don't what to check for typed characters. Perhaps SHELL_IGNORE_TYPEAHEAD would be better? -- Veni, Vidi, VW -- I came, I saw, I drove around in a little car. /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\ /// \\\ \\\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ /// \\\ help me help AIDS victims -- http://ICCF-Holland.org /// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/202106011647.151GlRLC2347333%40masaka.moolenaar.net.
