On Tue, Jun 1, 2021 at 11:47 AM Bram Moolenaar <[email protected]> wrote:
> Felipe Contreras wrote:
>
> > Clearly the code meant to check for SHELL_SILENT in order to send to
> > /dev/null, not SHELL_EXPAND.
> >
> > This works because all the callers of get_cmd_output that use
> > SHELL_SILENT also use SHELL_EXPAND.
> >
> > This has been there since Vim 5.0.
>
> I don't think the value should be changed. Unless you can show a
> situation where the wrong thing happens.
>
> There is one call where only SHELL_EXPAND is used in get_cmd_output().
> Thus applying the change does have an effect. It's not so easy to see
> how though.
The only callers of get_cmd_output() are:
* get_cmd_output_as_rettv: sets SHELL_SILENT
* find_locales: sets SHELL_SILENT
* expand_backtick: sets SHELL_SILENT if EW_SILENT
All callers of expand_backtick set EW_SILENT, otherwise they might get
"shell returned ..." messages.
> The naming is confusing. It looks like SHELL_EXPAND is used whenever
> the output of a non-interactive shell command is obtained, where we
> don't what to check for typed characters. Perhaps
> SHELL_IGNORE_TYPEAHEAD would be better?
I think it's meant for stuff like expand("~/").
--
Felipe Contreras
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/vim_dev/CAMP44s0cAN1dFTwCQKGgKBSsx5FwNqLYcEdhiLEmBRsTZRQ5_A%40mail.gmail.com.
