Hi, On Fri, Sep 29, 2023 at 2:51 PM errael <[email protected]> wrote:
> Shades of Java's PECS. > > There were two ways to deal with #12965 > <https://github.com/vim/vim/issues/12965>. > > 1. Adjust the parser to meet the spec. > > The spec currently states that: Object methods of the base class can be overruled. The signature (arguments, argument types and return type) must be exactly the same. The current implementation doesn't match with this spec. If we follow this spec, then the type in an overruled method cannot be a covariant or contra-variant. I think that will be limiting, as the method in an extended class may want to return a covariant type. > > 1. Change the spec and various implementation things. > > Doing 1. is backwards compatible with future implementation of the > requested features. > Doing 2. seems rushed. > > My first look, not running any code, this change seems to add little, at > the expense of *conceptual complexity*. I was in the process of manually > working through some things related to this, so I could make a comment, > when it got checked in (seemed pretty quick for a change that wasn't > understood). > Let me know if you see any cases that will break with the latest changs. > What's to rush to add new features that have not been debated? > > > No rush. I didn't see any objection to the proposal in https://github.com/vim/vim/issues/12965 and this is closer to the Dart spec. As the changes are minimal to support this, if needed, we can make adjustments. Regards, Yegappan -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/CAAW7x7%3DkLdEStPJ4smSDfmkqNVVm2Jjy6rmHoYD-LoNapEALeQ%40mail.gmail.com.
