On Feb 25, 2009, at 2:25 PM, björn wrote:
> It seems three colors that are in Vim are not included in the output
> of "showrgb", namely:
>
> darkyellow
> lightmagenta
> lightred
Yes, I noticed that in vimdiff of the original and generated plist.
However, since neither showrgb nor Wikipedia page on X11 colors list
those three colors I thought they could be safely omitted.
> I have added these manually to Colors.plist and pushed the changes.
Perhaps you think they are important to maintain compatibility in case
they were used previously in Vim?
If you want, we can add them to the initialization part before the
first for loop in rgb2plist.py. So, instead of starting with an empty
dictionary
colors = {}
we could start with
colors = dict(darkyellow=1234, lightmagenta=5678, lightred=90)
putting the original numbers in, of course. :-)
It's a small change to apply and easy to test if it works.
Still, if you don't have time I could apply it.
Then they would be generated from the program with all the other
numbers. We wouldn't need to think about forgetting them in case the
plist is ever re-generated (assuming that you committed rgb2plist.py
together with Colors.plist to the repo).
Zvezdan
--~--~---------~--~----~------------~-------~--~----~
You received this message from the "vim_mac" maillist.
For more information, visit http://www.vim.org/maillist.php
-~----------~----~----~----~------~----~------~--~---
