2009/6/25 Kazuki Sakamoto: > > I have implemented `+netbeans_intg' for MacVim. > clewn has finally worked with MacVim! > > http://clewn.sourceforge.net/ > > $ clewn > (gdb) > > $ MacVim.app/Contents/MacOS/Vim -g -nb:localhost:3219
Hi Sakamoto, That's great! I think a lot of people will appreciate this. I haven't tested the code yet but the patch looks good. I only have a few (trivial) comments at the moment: 1. What happens if setNetbeansSocket: is called twice with "socket == -1"? Same thing if called with two different values for "socket"? (I guess the way it is set up this will never happen but it doesn't hurt to be a bit paranoid and make this more robust by freeing all structures and setting them to nil before CFSocketCreate...() and making sure you don't call CFRelease() twice on the same structure.) 2. Check whitespace in feature.h/netbeans.c -- you should use "set et" in the core Vim source code files (at the moment there are spaces in some places where there should be tabs). Thanks for the patch, Björn --~--~---------~--~----~------------~-------~--~----~ You received this message from the "vim_mac" maillist. For more information, visit http://www.vim.org/maillist.php -~----------~----~----~----~------~----~------~--~---
