Hi Björn, On Fri, Jun 26, 2009 at 12:25 AM, björn<[email protected]> wrote:
> That's great! I think a lot of people will appreciate this. Thanks! I am happy to hear that. > I haven't tested the code yet but the patch looks good. I only have a > few (trivial) comments at the moment: > 1. What happens if setNetbeansSocket: is called twice with "socket == > -1"? Same thing if called with two different values for "socket"? (I > guess the way it is set up this will never happen but it doesn't hurt > to be a bit paranoid and make this more robust by freeing all > structures and setting them to nil before CFSocketCreate...() and > making sure you don't call CFRelease() twice on the same structure.) Ok, I have made sure it. > 2. Check whitespace in feature.h/netbeans.c -- you should use "set et" > in the core Vim source code files (at the moment there are spaces in > some places where there should be tabs). > Sorry, that was meant to read "set noet". understand. I have fixed about whitespace as other lines. By the way, we might need to implement `+balloon_eval' as well. src/gui_beval.c sakamoto --~--~---------~--~----~------------~-------~--~----~ You received this message from the "vim_mac" maillist. For more information, visit http://www.vim.org/maillist.php -~----------~----~----~----~------~----~------~--~---
0001-implemented-netbeans_intg_2.patch
Description: Binary data
