On 3 November 2010 17:38, Wincent Colaiuta <[email protected]> wrote: > Hi, > > I'm the author of the Command-T plug-in and I've received multiple > reports of a redraw issue in MacVim after moving to 7.3: > > https://wincent.com/issues/1692 > > The bug is that Command-T updates the status line, and then MacVim > repaints it immediately, causing the status line to appear blank. > > This issue is specific to MacVim and doesn't occur in upstream Vim > built from source. > > `git bisect` reveals that the commit which introduced the glitch is > commit ba4486860: > > https://github.com/b4winckler/macvim/commit/ba4486860ecda4b5e3584c0938abcc5046f1beaa > > The commit message reads: > >> Fix display corruption when dragging divider >> >> This fixes a bug where the screen would get corrupted when dragging a >> horizontal divider in full-screen mode. > > So the problem here is that it doesn't just fix the corruption while > dragging the horizontal divider in full-screen mode, it actually > breaks things when not in full-screen mode, and in fact when running > from the Terminal too (ie. not inside the Mac GUI do there aren't any > draggable dividers in that case). > > Any thoughts on a way to make this fix more specific (ie. to fix the > full-screen dragging issue without causing secondary breakage)? As a > quick guess, I thought I'd try swapping in the "NOT_VALID" flag > instead of the "CLEAR" one as shown in this gist: > > https://gist.github.com/661327 > > This does indeed make the Command-T disappearing status line issue go > away, and in my playing around with dividers in full screen mode, I > was unable to provoke any corruption. > > This is just my 30 second guess at a fix though, from someone who > doesn't really know the redrawing code at all, so it may be stupid. > > Thoughts?
Thanks for looking into this -- I have to take a look but I think your fix may be the right one. Please send me a patch (git format-patch) so that you appear as the patch author (if you wish). I don't remember how to recreate the display bug that the commit above fixed...I think you need to have both vertical and horizontal splits (with text in each view) and then drag the dividers. Björn -- You received this message from the "vim_mac" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php
