On 4 November 2010 09:13, Wincent Colaiuta <[email protected]> wrote: > On Nov 3, 9:11 pm, björn <[email protected]> wrote: >> >> Thanks for looking into this -- I have to take a look but I think your >> fix may be the right one. Please send me a patch (git format-patch) >> so that you appear as the patch author (if you wish). >> >> I don't remember how to recreate the display bug that the commit above >> fixed...I think you need to have both vertical and horizontal splits >> (with text in each view) and then drag the dividers. > > Ok, here's the patch: > > https://gist.github.com/662226 > > Full disclosure: > > - just to make sure that this change doesn't introduce a regression of > the display corruption issue, I tried many combinations of vertical > and horizontal splits with text in them, in both windowed and full- > screen mode, with and without the experimental renderer, and I > couldn't trigger any corruption > > - to be doubly sure, I also built Vim without the initial fix (ie. > with SOME_VALID rather than CLEAR or NOT_VALID) and even then I > couldn't reproduce the display corruption > > So, basically, I can't be 100% sure that this won't regress because > I'm unable to reproduce the original issue. Funnily enough, I reported > the display corruption ages ago: > > http://code.google.com/p/macvim/issues/detail?id=262 > > And using the recipe described there, I can't reproduce with any of > SOME_VALID, CLEAR and NOT_VALID.
Thanks. I just tried reproducing with snapshot 52 (the version you used when reporting this issue originally) and I can't repro either. Weird. I'm be happy to merge this, if there is a regression we'll just have to find another fix, but...I notice several places in window.c where the same line that you just patched appears. Should we perhaps change all of them to NOT_VALID instead of CLEAR? I have to take a closer look, but I'd value your input. Björn -- You received this message from the "vim_mac" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php
