On Sat, Jun 29, 2013 at 12:28 AM, Jimmy Zelinskie wrote: > On Friday, June 28, 2013 2:33:19 AM UTC-4, björn wrote: > > On Thu, Jun 27, 2013 at 10:01 PM, Jimmy Zelinskie wrote: > > > > > As per the discussion at > https://github.com/mxcl/homebrew/pull/20831#discussion_r4917643 > > > > > > > > > > The required macro MAC_OS_X_VERSION_MAX_ALLOWED requires > > > > > AvailabilityMacros.h to be defined. This diff is all that's required > upstream, the rest is brew specific: > > > > > > > > > > diff --git a/src/os_unix.c b/src/os_unix.c > > > > > index bb4c10e..00d9728 100644 > > > > > --- a/src/os_unix.c > > > > > +++ b/src/os_unix.c > > > > > @@ -18,6 +18,10 @@ > > > > > * changed beyond recognition. > > > > > */ > > > > > > > > > > +#if defined(__APPLE__) > > > > > +#include <AvailabilityMacros.h> > > > > > +#endif > > > > > + > > > > > /* > > > > > * Some systems have a prototype for select() that has (int *) > instead of > > > > > * (fd_set *), which is wrong. This define removes that prototype. We > define > > > > > > > > > > -- > > > > > -- > > > > > > > > Thanks for the patch. > > > > > > > > What is the reason that we have to pollute os_unix.c (which has > > > > nothing to do with OS X) with an OS X-only header? > > > > > > > > What exact problem does this patch address and is there perhaps a > > > > better way to solve it? > > > > > > > > Björn > > I agree -- this was just the patch located at the bottom of the pull > request on the homebrew issue tracker. Vim builds if you place the #include > in os_mac.h > > On Friday, June 28, 2013 5:05:03 PM UTC-4, Bram Moolenaar wrote: > > Jimmy Zelinskie wrote: > > > > > > > > > As per the discussion at > https://github.com/mxcl/homebrew/pull/20831#discussion_r4917643 > > > > > > > > > > The required macro MAC_OS_X_VERSION_MAX_ALLOWED requires > > > > > AvailabilityMacros.h to be defined. This diff is all that's required > upstream, the rest is brew specific: > > > > > > > > > > diff --git a/src/os_unix.c b/src/os_unix.c > > > > > index bb4c10e..00d9728 100644 > > > > > --- a/src/os_unix.c > > > > > +++ b/src/os_unix.c > > > > > @@ -18,6 +18,10 @@ > > > > > * changed beyond recognition. > > > > > */ > > > > > > > > > > +#if defined(__APPLE__) > > > > > +#include <AvailabilityMacros.h> > > > > > +#endif > > > > > + > > > > > /* > > > > > * Some systems have a prototype for select() that has (int *) > instead of > > > > > * (fd_set *), which is wrong. This define removes that prototype. We > define > > > > > > > > So, on what systems is AvailabilityMacros.h available? > > > > > > > > Isn't this a chicken-egg problem? > > > > > > > > -- > > > > Veni, Vidi, Video -- I came, I saw, I taped what I saw. > > > > > > > > /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net > \\\ > > > > /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/\\\ > > > > \\\ an exciting new programming language -- http://www.Zimbu.org > /// > > > > \\\ help me help AIDS victims -- http://ICCF-Holland.org > /// > > This documentation[1] leads me to believe that OSX 10.2+ supports it. This > homebrew pull request[2] cites that it has been built successfully on > 10.8.4-x86_64 and 10.7.5-i386. > > [1] > http://wiki.herzbube.ch/index.php/Mac_OS_X_Programming#Availability_Macros > [2] https://github.com/mxcl/homebrew/pull/20473#issuecomment-19434950 >
Usually the AvailabilityMacros.h header gets included when you pull in a Carbon/Cocoa header - it would be good to know why this is problem is showing up on 10.9 but nowhere else (or does it?). On the other hand, placing the include at the top of os_mac.h should be harmless as this header should be present when building on a Mac. At the moment I don't think it is urgent to patch this, since 10.9 has not yet been publicly released, but if somebody with access to 10.9 took a closer look it would certainly be helpful (as I probably won't get 10.9 myself for a long time). Björn -- -- You received this message from the "vim_mac" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_mac" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
