On 03/09/2013 02:02 AM, Chris Evich wrote:
On 02/27/2013 10:20 PM, Alex Jia wrote:
+    variants:
+        ...
+                                            options =

Any objection if I rename this to 'numatune_options'?


It's a little redundant, we can know this option belongs numatune testing from previous
naming, for example:

(6/52) *virsh_numatune*.positive_testing.*get_numa_parameter*.shutoff_guest.*options*.current: PASS (0.59 s) (7/52) *virsh_numatune*.positive_testing.*set_numa_parameter*.shutoff_guest.change_mode.*options*.config.preferred: PASS (0.68 s)

Although I know you want to avoid naming conflict, the following naming is indeed redundant:


(6/52) *virsh_numatune*.positive_testing.*get_numa_parameter*.shutoff_guest.*numatune_options*.current: PASS (0.59 s) (7/52) *virsh_numatune*.positive_testing.*set_numa_parameter*.shutoff_guest.change_mode.*numatune_options*.config.preferred: PASS (0.68 s)
_______________________________________________
Virt-test-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/virt-test-devel

Reply via email to