Dne 16.4.2013 09:50, Lukáš Doktor napsal(a):
Dne 12.4.2013 08:41, Xiaoqing Wei napsal(a):
This would prevent case error when test with QMP
as it uses 'inject-nmi' instead of 'nmi'
Signed-off-by: Xiaoqing Wei <[email protected]>
---
tests/kdump.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tests/kdump.py b/tests/kdump.py
index 4d8ce8d..ebe4276 100644
--- a/tests/kdump.py
+++ b/tests/kdump.py
@@ -41,7 +41,7 @@ def run_kdump(test, params, env):
if crash_cmd == "nmi":
session.cmd("echo 1 > /proc/sys/kernel/unknown_nmi_panic")
- vm.monitor.cmd('nmi')
+ vm.monitor.nmi()
On the second thought, better name for the function would be
inject_nmi(). I guess it's not a big deal but if you choose to modify
it, please update the commit message to something more self-explanatory,
eg.:
"Use the new framework function inject_nmi() to initiate kdump."
Regards and sorry for not noticing this earlier,
Lukáš
else:
logging.info("Triggering crash on vcpu %d ...", vcpu)
session.sendline("taskset -c %d %s" % (vcpu, crash_cmd))
Acked-by: Lukáš Doktor <[email protected]>
_______________________________________________
Virt-test-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/virt-test-devel
_______________________________________________
Virt-test-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/virt-test-devel
