On 04/17/2013 03:33 PM, Lukáš Doktor wrote:
Dne 16.4.2013 10:45, Qingtang Zhou napsal(a):
* On 2013-04-12 14:41:29 +0800, Xiaoqing Wei ([email protected]) wrote:
This would prevent case error when test with QMP
as it uses 'inject-nmi' instead of 'nmi'
Signed-off-by: Xiaoqing Wei <[email protected]>
---
tests/kdump.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tests/kdump.py b/tests/kdump.py
index 4d8ce8d..ebe4276 100644
--- a/tests/kdump.py
+++ b/tests/kdump.py
@@ -41,7 +41,7 @@ def run_kdump(test, params, env):
if crash_cmd == "nmi":
session.cmd("echo 1 > /proc/sys/kernel/unknown_nmi_panic")
- vm.monitor.cmd('nmi')
+ vm.monitor.nmi()
Hi, Xiaoqing,
The test scripts in the top-level of tests directory are used
for all virt-test, you can confirm this point from their
config files:
1 - kdump: install setup image_copy unattended_install.cdrom
2 virt_test_type = qemu libvirt
Good catch. Maybe you could add 'virt_test_type = qemu' into the nmi
variant...
Is libvirt using this case? Maybe we need a clear check about
virt_test_type. correct virt_test_type or make sure test script works
for all virt_test_type.
The config shows this kdump test is used for libvirt test
as well.
And I guess libvirt doesn't provide a monitor in its VM class,
so this script will fail when it's used in libvirt test.
A better solution is providing a new API in VM level (in
qemu_vm.VM class), call the 'vm.monitor.nmi()' in this new
API.
Since the problem is existed since it's put in 'tests' directory,
I can help you send a new version of patch.
_______________________________________________
Virt-test-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/virt-test-devel
_______________________________________________
Virt-test-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/virt-test-devel
_______________________________________________
Virt-test-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/virt-test-devel
