* On 2013-07-16 09:00:04 +0800, Yu Mingfei ([email protected]) wrote: > On 07/16/2013 12:58 AM, Lucas Meneghel Rodrigues wrote: > >Hi guys, I had to yank one commit from next today: > > > >pick 25bc565 virttest.aexpect: Fix old class Spawn definition. > > > >commit 25bc565b0317514db1538e2328350a753c23c945 > >Author: Yu Mingfei <[email protected]> > >Date: Fri Jul 12 10:41:55 2013 +0800 > > > > virttest.aexpect: Fix old class Spawn definition. > > > > The base class Spawn for ShellSession was defined in old > >way(class Spawn). > > Then we can not use super() for inherited classes: > > TypeError: super() argument 1 must be type, not classobj > > > > Signed-off-by: Yu Mingfei <[email protected]> > > > >Because this was breaking the qemu tests big time. After the 1st > >PASS on a typical qemu test run, we get a: > > > >>12:36:42 ERROR| FAIL migrate.default.unix -> AttributeError: > >>'Expect' object has no attribute 'lock_server_running_filename' > > > >While I'm not saying aexpect can't be touched, one needs to be > >very careful when modifying it. At least a good run of the default > >qemu test set, and possibly some other qemu related test sets must > >be done. > > > >This pull request can be fixed by carefully changing inheritances > >and attribute assignment, but I'll leave that to the author. You > >can submit it again once you are reasonably sure it won't break > >the tree in obvious ways. > > > >Thanks! > > > >Lucas > > > > Thanks for you reminder, I did not realize that it will cause that > problem. :D > I'll look again at this pull request. Hi, we noticed this problem last week, and there was a probably fix pullreq sent by ypu. https://github.com/autotest/virt-test/pull/631 Please have a look at the last patch.
_______________________________________________ Virt-test-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/virt-test-devel
