On 07/17/2013 02:13 PM, Feng Yang wrote:
On 07/16/2013 12:58 AM, Lucas Meneghel Rodrigues wrote:
Hi guys, I had to yank one commit from next today:
pick 25bc565 virttest.aexpect: Fix old class Spawn definition.
commit 25bc565b0317514db1538e2328350a753c23c945
Author: Yu Mingfei <[email protected]>
Date: Fri Jul 12 10:41:55 2013 +0800
virttest.aexpect: Fix old class Spawn definition.
The base class Spawn for ShellSession was defined in old
way(class Spawn).
Then we can not use super() for inherited classes:
TypeError: super() argument 1 must be type, not classobj
Signed-off-by: Yu Mingfei <[email protected]>
Because this was breaking the qemu tests big time. After the 1st PASS
on a typical qemu test run, we get a:
12:36:42 ERROR| 'Expect' object has no attribute
'lock_server_running_filename'
12:36:42 ERROR| Exception raised during postprocessing: 'Expect'
object has no attribute 'lock_server_running_filename'
12:36:42 ERROR|
12:36:42 ERROR| Traceback (most recent call last):
12:36:42 ERROR| File
"/home/lmr/Code/virt-test.git/virttest/standalone_test.py", line
191, in run_once
12:36:42 ERROR| params = env_process.preprocess(self, params, env)
12:36:42 ERROR| File
"/home/lmr/Code/autotest.git/autotest/client/shared/error.py", line
138, in new_fn
12:36:42 ERROR| return fn(*args, **kwargs)
12:36:42 ERROR| File
"/home/lmr/Code/virt-test.git/virttest/env_process.py", line 499, in
preprocess
12:36:42 ERROR| process(test, params, env, preprocess_image,
preprocess_vm)
12:36:42 ERROR| File
"/home/lmr/Code/virt-test.git/virttest/env_process.py", line 283, in
process
12:36:42 ERROR| _call_image_func()
12:36:42 ERROR| File
"/home/lmr/Code/virt-test.git/virttest/env_process.py", line 259, in
_call_image_func
12:36:42 ERROR| if vm is not None and vm.is_alive() and not
vm.is_paused():
12:36:42 ERROR| File
"/home/lmr/Code/virt-test.git/virttest/qemu_vm.py", line 152, in
is_alive
12:36:42 ERROR| return not self.is_dead() and (not self.monitor or
12:36:42 ERROR| File
"/home/lmr/Code/virt-test.git/virttest/qemu_vm.py", line 160, in
is_dead
12:36:42 ERROR| return not self.process or not
self.process.is_alive()
12:36:42 ERROR| File
"/home/lmr/Code/virt-test.git/virttest/aexpect.py", line 584, in
is_alive
12:36:42 ERROR| return _locked(self.lock_server_running_filename)
12:36:42 ERROR| AttributeError: 'Expect' object has no attribute
'lock_server_running_filename'
12:36:42 ERROR|
12:36:42 ERROR| FAIL migrate.default.unix -> AttributeError:
'Expect' object has no attribute 'lock_server_running_filename'
While I'm not saying aexpect can't be touched, one needs to be very
careful when modifying it. At least a good run of the default qemu
test set, and possibly some other qemu related test sets must be done.
This pull request can be fixed by carefully changing inheritances and
attribute assignment, but I'll leave that to the author. You can
submit it again once you are reasonably sure it won't break the tree
in obvious ways.
Thanks!
Lucas
This patch still in next?
https://github.com/autotest/virt-test/commit/df3f719d1aed5a21f74e851053f74fddbee8c91a
Oh, yes, I just thought lmr had removed it.
And ypu:
Have you finished the pickle problem of new class style?
_______________________________________________
Virt-test-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/virt-test-devel
_______________________________________________
Virt-test-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/virt-test-devel
--
Best Regards
Yu Mingfei
_______________________________________________
Virt-test-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/virt-test-devel
