On 09/03/2013 09:10 PM, Lucas Meneghel Rodrigues wrote:
Hello folks:
For about a week we've been talking about making the coding style for
both virt-test and autotest, that is PEP8 [1] + some exceptions to
become PEP8.
This proposal would bring a few changes to the current style, mainly:
* imports
* spacing between functions
The advantage of following the spec more closely is automatic
verification and fixing through scripts (autopep8 [2]). In case we opt
to go forward with the proposal, we'd need to:
* Develop scripts to do mass conversion of the non compliances
* Migrate the current code. We might as well do the docstring
conversion, assuming it's easy to at least semi-automate the process.
Thoughts?
Another thing I did forget to mention is that we're looking to use codespell
https://github.com/lucasdemarchi/codespell
As an auxiliary tool to catch common misspellings in the code, and
include it as an auxiliary tool that makes us avoid mistakes, just like
pylint, reindent.py and autopep8 are used. This also means we'll have
more massive, full tree reaching commits. I'd like to do this sooner
rather than later, and it also means more rebased pull requests.
I for one think it is worth the effort. I made some preview runs on a
private branch and the results look sweet.
So I'd like to hear any complaints before this is implemented.
Lucas
[1] http://www.python.org/dev/peps/pep-0008/
[2] https://pypi.python.org/pypi/autopep8
_______________________________________________
Virt-test-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/virt-test-devel
_______________________________________________
Virt-test-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/virt-test-devel
