On 09/05/2013 12:57 AM, Lucas Meneghel Rodrigues wrote: > First patches that introduce the mentioned tools to virt-test (will be > extended to autotest) > > https://github.com/autotest/virt-test/pull/826 > > If nobody pronounces until Friday, I intend to do the mass conversions > during the weekend. > > Cheers!
(Putting on my dumb-user hat, pretending I don't know nuffin') The old check_patch seems to be happy about these changes :D [cevich@cevich virt-test]$ tools/check_patch.py -g 826 12:51:26 INFO | Detected project name: virt-test 12:51:26 INFO | Log saved to file: /tmp/check-patch.log 12:51:26 INFO | Checking github pull request #826 12:51:26 INFO | [cevich@cevich virt-test]$ The new check_patch is giving me some trouble: [cevich@cevich virt-test]$ tools/check_patch.py -g 826 Unable to find command <pep8>, it may need to be installed [cevich@cevich virt-test]$ sudo yum install -y pep8 ... No package pep8 available. Error: Nothing to do (That was on F19 BTW, I suspect similar problem on RHEL 7 nightly) Maybe suggest in the error where/how one can obtain pep8? I just did easy_install pep8, but that's not all that's needed: [cevich@cevich virt-test]$ tools/check_patch.py -g 826 12:57:53 INFO | Detected project name: virt-test 12:57:53 INFO | Log saved to file: /tmp/check-patch.log 12:57:53 INFO | Checking github pull request #826 12:57:53 INFO | Unable to find command <autopep8>, please add option --dryrun. So two things are needed, but only one is mentioned at a time, mmmm, annoying. Anyway, if I easy_install autopep8 and... [cevich@cevich virt-test]$ tools/check_patch.py -g 826 12:59:50 INFO | Detected project name: virt-test 12:59:50 INFO | Log saved to file: /tmp/check-patch.log 12:59:50 INFO | Checking github pull request #826 12:59:50 INFO | [cevich@cevich virt-test]$ Success? Failure? Did it do anything? Looking at the log... ... WARNI|base_utils:1076| run process timeout (60) fired on: libguestfs-test-tool ERROR|check_patc:0533| virttest.utils_libguestfs_unittest had 0 failures and 1 errors. ERROR|check_patc:0533| virttest.virsh_unittest had 0 failures and 11 errors. ERROR|check_patc:0839| Patch checking found files with problems: ...some modules listed, but no idea why it is error... ERROR|check_patc:0806| Full tree check found files with problems: ...every file is listed as ERROR, but no reasons given... DEBUG|base_utils:0114| [stderr] /bin/bash: tools/codespell/codespell.py: No such file or directory Ooodles of these messages, I'm guessing because the module isn't in the next branch? That might make it a pain to update in the future, what if there's a bug in next's codespell, shouldn't it use the version from the tree as checked out by check_patched? Also, since the check_patch.py command produced no errors on it's output, am I to take that as a PASS, FAIL, or do I have to look at the log every time? The log only tells me there are errors, and gives no clues as to where/what they are :S (removing dumb-user hat) -- Chris Evich, RHCA, RHCE, RHCDS, RHCSS Quality Assurance Engineer e-mail: cevich + `@' + redhat.com o: 1-888-RED-HAT1 x44214 _______________________________________________ Virt-test-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/virt-test-devel
