Video URL: https://www.youtube.com/watch?v=nS8EpfSKbxc
Autotest Weekly Hangout 2013-09-05 (CST edition)
Etherpad: https://autotest.etherpad.mozilla.org/1?
Hangout URL:
https://plus.google.com/hangouts/_/c14932971e4300574ec7a9baf019054c15d15bd6
Telephone bridge:
https://www.intercallonline.com/listNumbersByCode.action?confCode=9197544214
Highlights
Autotest and virt-test went PEP8/sphinx this week, on-tree documentation
is our next goal. Meanwhile, our co-workers have been producing a lot of
new virt-test code, as usual.
Commits on next - autotest
Thanks to a slower period on autotest, I could perform the mass
conversion more easily. This week was all about fixing unittests and
straightening up the code base.
Lucas Meneghel Rodrigues (11):
distro/boottool: Fix __all__ tuple (pylint fix)
Mass spelling fixes
tools: add tool for pep8 reformatting
tools: add pep8 check into check_patch
tools: Add codespell
tools: Sync PEP8 and check_patch scripts with virt-test
PEP8 mass fixes
Mass docstring fix
unittests: Fixing broken unittests with latest refactors
CODING_STYLE: Update document reflecting the move to PEP8
More docstring fixes
Commits on next - virt-test
On virt-test, after virt-test 2013.09.03 was relased, beyond the PEP8
mass conversion, we also had lots of hard to track unittest problems,
QEMU saw an update to the the sr-iov related code, and a new library,
utils_conn, a neat module to handle network connections.
Chris Evich (7):
Merge pull request #814 from yumingfei/fix_virsh_module
virt-libvirt: Pylint fixes for vm_xml
virt-libvirt: Unittest causing failures in others
virt-libvirt: Fix small bug in storage_unittest
virt-libvirt: Avoid future param. order problems
Merge pull request #833 from yangdongsheng/libvirt_storage_unittest
virt-libvirt: Error message enhancement
Dongsheng Yang (2):
virttest.libvirt_storage_unittest: remove ModuleLoadCheckVirsh class.
tool-pep8: update the comment in run_pep8 module.
Feng Yang (15):
virttest.qemu_vm: But fix in add_pcidevice.
virttest.qemu_vm: generate mac address if not available in nic
and add vf with mac
qemu.tests: make sr_iov_hotplug_negative.py works with new
PciAssignable class
qemu.tests: Make sr_iov_hotplug.py works with new PciAssignable class
qemu.tests.cfg.sr_iov: Config update.
virttest/test_setup:Add pf_vf_info element and get_pf_vf_info
function into PciAssignable
virttest.test_setup: Add get_vf_num_by_id() function to
PciAssignable class
virttest/test_setup: Update _get_pf_pci_id() function.
virttest:test_setup: update get_vf_devs() and get_pf_devs() function
virttest.test_setup: Update PciAssignable class
virttest.test_setup: Change docstring from Doxygen to sphinx in
PciAssignable class
virttest.test_setup: Support vfio for pf/vf pci assign
virttest.qemu_vm: Support device_driver parameter in
pci_assignable related device.
virttest.test_setup: Fix issue that 'pci-assign' is treated as
not support in some host which really support it.
virttest.test_setup: Only get same group device for vfio-pci.
Li Yang (1):
virt: Remove vcpucount_live() and fix vcpucount() in virsh.py
Lucas Meneghel Rodrigues (18):
virttest.qemu_devices: Lose verbose=False incompatible with at 0.14
Merge branch 'next' - Virt Test 2013.09.03
boottool/version: Fix __all__ dictionary
libvirt_xml_unittest: Fix wrong arguments passed to function
tools: Add codespell
tools/check_patch.py: Add codespell check
run_pep8 refactor
Mass spelling fixes
tools/run_pep8.py: Ignoring E501,W601
PEP8 mass fixes
tools/check_patch.py: Fix incorrect logic
Mass docstring fix
tools/run_pep8: Add own logging config class
Add CODING_STYLE document
More docstring fixes
run: Docstring fix
virttest.qemu_vm: PEP8 fixes
virttest.test_setup: PEP8 fixes
Lukáš Doktor (3):
Merge pull request #823 from ypu/low
virttest.qemu_devices: Support blk_extra_params
virttest.qemu_vm: Fix nic_extra_params
Xu Tian (4):
qemu.tests: add scenario '1 0' in test loop
qemu.tests: fix duplicate properites for device
qemu.tests: make mutli_disk test works for linux guest
qemu.test: fix module reload failed issue
Yang Feng (2):
Merge pull request #832 from ypu/host_setup_flag
Merge pull request #694 from FengYang/sr-iov
Yiqiao Pu (4):
tests.cfg: Set up the lowest_mem for unattended_install
virttest.utils_misc: Convert host_setup_flag into int
qemu.test.cfg: Add cmd /c for windows disk write test
qemu.test.cfg: Add two sub test for windows disk write
Yu Mingfei (6):
virttest.virsh: Fix error of referenced before defined.
libvirt.tests: Fix pylint complaint for virsh connect.
virttest.utils_conn_unittest: method conn_finish has been changed
to conn_recover.
virttest.libvirt_vm: Add domjobabort method for VM class.
libvirt.tests: Add testcases for migration of multiple vms.
virttest: Add unittest for libvirt_storage module.
Yunping Zheng (2):
virttest.test_setup: changed forward delay to 4
qemu.tests.nic_bonding : Close NetworkManager before bonding
yangdongsheng (13):
libvirt-tests: fix virsh_vcpuinfo test, mv shutoff_option test
from error_test to normal test.
libvirt-tests: virsh_vcpuinfo, add more debug message.
utils_libvirtd_unittest: remove skipIf to avoid incompatible
issue for python2.6
Add a method named sub_else_add in RemoteFile class.
Add utils_conn module in virttest.
Add test for virsh connect.
utils_conn: add more comments and make tmp_dir unique.
utils_conn: Add more unittest for utils_conn.
virttest.utils_conn: add auto_recover into __init__().
libvirt-tests: replace /var/run/libvirt/lxc with
/usr/libvirtexec/libvirt_lxc.
Merge pull request #805 from yangdongsheng/update_virsh_vcpuinfo
tools: add tool for pep8 reformatting
tools: add pep8 check into check_patch
Pull requests still in review
Autotest
https://github.com/autotest/autotest/pull/733 -
client.shared.utils_cgoup: Two little modifications in utils_cgroup
https://github.com/autotest/autotest/pull/736 -
client.shared.iscsi: Update iscsi.py
https://github.com/autotest/autotest/pull/738 -
Remove gnuplot from package dependence and improve the test for Ubuntu
by looking for /etc/debian_release. Nice cleanup by Ruda, we can get
away without gnuplot in autotest.
https://github.com/autotest/autotest/pull/739 -
RPC Interface: Add get_server_status() method - Dashboard
Virt Test
https://github.com/autotest/virt-test/pulls - We have 49 open pull
requests, a hefty increase from last week (we had about 35 open pull
requests by that time). That means we'll have to get back to review and
close pull requests aggressively.
Autotest reporting work
New Job view mockups developed
RPC server get_server_status() method implemented, and a corresponding
dashboard implementation in the prototype web interface, that can be
seen in the autotest pull request
https://github.com/autotest/autotest/pull/739
I still have leaps and bounds to evolve in terms of making a decent web
application. Hopefully things will get better in the coming months.
Grid maintenance
The production grid is back on track, fully functional, thanks to
Cleber's tireless work.
A bunch of new machines were added to the test grid, at last!
Mass coding style conversion
After a fair amount of work, we have new tools to help us to keep the
average code quality of our projects good:
tools/run_pep8.py
tools/codespell/codespell.py
These tools were used to perform a mass code conversion on both
virt-test and autotest, as well as a mass spelling fix and a conversion
from the old doxygen format to the new sphinx format.
Although I understand the inconvenience for the pull requests already
out there, doing this conversion sooner rather than later is better,
since it is unrealistic to suppose people would stop producing pull
requests so that we could stop and fix the code base.
Make sure you actually use the tools provided to check your new code
before you send a pull request. I will be extremely disappointed if I
see pull requests that have a lot of spelling and PEP8 inadequacies.
Libvirt updates
TODO toto Wiki + issues
Excellent Peer review
Excellent code growth pace
Nice mix of focus on core + tests
Questions Corner
TODO
lmr
Assist Ruda as he is getting acquainted with the rather busy schedule of
an autotest/virt-test maintainer.
Autotest UI work
Autotest web service work
cevich
Put TODO Wiki + issues
patch review
aexpect + unittest improvements
documentation
cleber
Autotest 0.15.1 RPM in Fedora
Move "software installer" from virt-test back to autotest, adding
unittests and docs
This is necessary for the component isolation work v2, because
installing say qemu from koji will already register that software
component in the test database
Coming along nicely, expect pull request by next week
UPDATE: will wait on component isolation work to get in, because the
rebasing has not been fun.
jzupka
review pull-requests
rebase my old pull-request
bugs rtc
rmoura
review pull-requests with lrmr's help
ldoktor
qemu_devices
PCI support for PCI switch/bridge/...
multi_disk_hotplug test - get it upstream
reviewing pull requests
fixing bugs
PEP8 - what is the possibility to disable E127 and E128???
kvm-qe(BJ):
Keep on bugs fix and case development. And each of us will force on one
or two features in the following list:
ypu: whql cases
yunzheng: virtual network bugs fix
xutian: cdrom, storage vm migration
fyang: device assignment
qzhou: timer device will send patch as [email protected] in future.
_______________________________________________
Virt-test-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/virt-test-devel
