Etherpad: https://autotest.etherpad.mozilla.org/1?

Youtube Video: https://www.youtube.com/watch?v=jM_uUn5aNbM#t=91


Highlights

After a while battling the problem of resource leaks in virt-test, the problems were fixed, and now virt-test cleans both all fds and the tmp files it produces. Other important bug was worked around this week, and the imperfect solution will give us time to figure out things properly.

Besides fixing bugs, some options for so called the 'repo split' were considered. Also, some thought to better reporting of the stand alone suite was given.

Commits on master - autotest

Small fixes to the documentation work by Ruda, and some other small fixes to the SoftwareManager and Distro detection layer, by Cleber and Darren Hart

Cleber Rosa (2):
      software manager: fallback to lowercase distro name
      utils/check_patch.py: Change 'next' branch to 'master'

Darren Hart (1):
      software_manager: Search dict with lowercase distro name, add logging

Lucas Meneghel Rodrigues (1):
      software_manager: add support for single package upgrade

Ruda Moura (1):
      documentation: set sys.path to use autotest library.

Rudá Moura (1):
      Merge pull request #769 from ruda/api-doc4

Commits on master - virt-test

We had quite the cleanup week. Finally, the fd leak problem was entirely fixed, and now temporary files are properly cleaned up after each test. We also fully embraced a workflow that strain less the developers (now we will avoid fixing pull requests, and ask people to rebase their PRs, plus no next branch to confuse people).

Besides, we had the usual assortment of new tests on both the libvirt and qemu side, and jzupka contributed some gluster tests to make our testing more complete.

Cong Li (1):
      fix typo of iozone_cmd

Dongsheng Yang (1):
      libvirt-tests: virsh_domfstrim, remove global using.

Feng Yang (6):
      virttest.utils_test.__init__: Add detail error log in get_time()
      shared.cfg.guest-hw: Add raw_dd variant.
qemu.cfg.virtual_nic_send_buffer: Update configure for netperf_udp sub case.
      qemu.cfg.host-kernel: Set nettype to bridge when vhost used
shared.cfg.guest-hw: Update pf_assignable and vf_assignable configure to fit framework changes.
      qemu.tests: Add sr_iov_sanity new test case.

Hao Liu (4):
      virttest.env_process: Tcpdump is stopped too early
      libvirt-tests: Backup inactive domain XML
      virttest.libvirt_vm: Fix one line cond-expr
      libvirt.get_started: Added non-interactive option

Jiří Župka (10):
virt: Fix filesystem type in mtab don't have to be same like fs in mount cmd
      virt: Allows get_net_if filter interfaces by state.
virt: Fix import error when AUTOTEST_PATH is relative and work dir is changed.
      virt: Adds support for filesystem backend to storage.
      virt: gluster split create and get path functionality.
      virt: Adds support for qcow2 backing file.
virt: Adds support for check disk in storage with native support (gluster).
      virt: env_preprocess adds support for image backend.
      virt: Change config files to use image_backend config.
      virt: Adds some gluster tests.

John Ferlan (5):
      virsh_domfstrim: Check for existence of lsscsi first
      virsh_vcpucount: Adjust --guest option testing
      virsh_setmem: Reduce churn for libvirtd restart
      virsh_nodedev_create_destroy: Use TestNAError
      virsh_snapshot_create_as: Fix error recovery

Kyla Zhang (3):
      Wrap command domfstrim
      Add config for domfstrim
      Add test for domfstrim

Li Yang (1):
      virt: Add 'session' parameter to RemoteRunner class

Lucas Meneghel Rodrigues (49):
      Merge pull request #1141 from ypu/cdrom
      Merge pull request #1116 from humanux/suspend_netperf
      Merge pull request #1146 from Hao-Liu/non_interactive
      Merge pull request #1115 from Hao-Liu/workbranch
      virttest.utils_test: Fix undefined variable error
      virttest.standalone_test: Shut down all VMs at the end of ./run
      virttest.utils_net: Fix logging message
      Merge pull request #1151 from autotest/shutdown-vms-post-run
      virttest: Close and re-establish serial console every test
      virttest.aexpect: Put shell files on aexpect process dir
      virttest.aexpect: Remove the entire aexpect tmp dir on close()
      virttest.qemu_vm: Bugfix - make seabios file to be deleted on destroy
      virttest.qemu_vm: Better naming and management of vm create lock file
      virttest.aexpect: Simplify base dir name
virttest.utils_net: Make db filename a module constant and delete lock
      virttest.aexpect: Introduce clean_tmp_files utility function
      virttest.utils_net: Introduce clean_tmp_files utility function
      virttest.standalone_test: Improve tmp files cleanup code
      run: Kill vms and clean tmp files on Ctrl+C handler
      virttest.data_dir: Add clean_tmp_files() utility function
      Merge pull request #1160 from autotest/fd-cleanup
      Merge pull request #1163 from rbbratta/rhel65
      virttest.aexpect: Do not remove the aexpect dir wholesale
      Merge pull request #1168 from autotest/aexpect-fix
      virttest.qemu_devices: Fix warning messages
      virttest.qemu_vm: Readability fixes
      virt-test: Fix old references to kvm-autotest
      Merge pull request #1175 from autotest/readability-fixes
      Merge pull request #1100 from jzupka/glusterfs-2
      Merge pull request #1117 from humanux/set_link
      Merge pull request #1118 from humanux/zero_copy
      Merge pull request #1119 from humanux/qemu_option_check
      Merge pull request #1169 from jferlan/virsh_domfstrim
      Merge pull request #1170 from jferlan/virsh_vcpucount
      Merge pull request #1172 from jferlan/virsh_setmem
      Merge pull request #1173 from jferlan/virsh_nodedev_create_destroy
      Merge pull request #1174 from jferlan/virsh_snapshot_create_as
      Merge pull request #1150 from Antique/virsh-emulatorpin
      virttest.utils_net: Don't remove virt DB lock upon unlocking
      virttest.utils_net: Clean DB lock file on clean_tmp_files()
      virttest.qemu_vm: Don't delete vm create lock file on unlock
      virttest.standalone_test: Clean VM create lock on clean_tmp_files()
      Merge pull request #1176 from autotest/bugfixes
      Merge pull request #1159 from jzupka/virt-fix-path
      run: Fix bug in commit efadf86
      Merge pull request #1178 from autotest/bugfix
      virttest.qemu_vm: Fix issue #381
      Merge pull request #1179 from autotest/fix-381
      Merge pull request #1180 from autotest/virtnet2

Pavel Hrdina (1):
      virsh.emulatorpin: fix the way we get a cgroup path

Ross Brattain (1):
      guest-os: add RHEL6.5

Rudá Moura (1):
      Merge pull request #1128 from ypu/bugfix

Shuping Cui (1):
      qemu.tests: add enable s3/s4 params for qemu_guest_agent.cfg

Swapna Krishnan (1):
      qemu/cfg/tests-spice.cfg: Fix wrong name value for celt051_devel_url

Xu Tian (1):
      virt.tests: fix no ip address for extra nics

Yang Feng (3):
      Merge pull request #1124 from spcui/qemu_guest_agent
      Merge pull request #1139 from ypu/bugfix1
      Merge pull request #1184 from CongSmile/iozone

Yiqiao Pu (13):
      qemu.tests: update max_memory to keep guest from oom in ksm_base
      qemu.tests: Remove unreadable codes from linux console in seabios
      virttest: Record command output for compare_image in qemu_storage
      qemu.tests.cfg: Make floppy_test support Windows guests
      qemu.tests: Add flags for add_flag test
      qemu.tests: Correct the timeoout type to float
      qemu.tests.cfg: Update main monitor in qmp_basic test
      qemu.tests.cfg: Use image_snapshot for enable snapshot for each guest
      virttest: Update cdrom image file name
      Merge pull request #1127 from FengYang/update7
      Merge pull request #1158 from humanux/e1000_regex
      Merge pull request #1138 from FengYang/sanity
      Merge pull request #1188 from xutian/multi_nic_ping

Yunping Zheng (6):
      qemu.test: add test case for guest suspend under nic stress
      qemu.test: make set_link test support multiple queues
      qemu.test: Add vhost_net zero copy test
      qemu.test: add qemu device options check
share.cfg.guest-os.Windows.cfg : Modify the regex of e1000 Description
      virt.virtnet : update vm.virtnet when guest reboot

Arc

New release, now two contributors! Thanks Ruda!

Changes from last version:

SPEC: update to version 0.6.0
release: bump version to 0.6.0
python-arc.spec: follow suggestion from rpmlint
arc/cli/actions/regressionpoint.py: replace the diff format
arcli: add testenvironment action
arcli: add linuxdistro action
arc/utils.py: add utility module
arc/testenvironment.py: use autotest.shared module
samples/api/get-interface-version.py: use autotest.shared module
arc/cli/actions/job.py: implemented `arcli job --show` action
arc.shared: update code to make use of this new module
arc.shared: create a new top level module and namespace
arc/cli/app.py: do not mention action since it could be None
python-arc.spec: following further packaging suggestions
arc/tko/test.py: add API level support for TKO Test
arcli: add regressionpoint action
arc/testenvironment.py: add API level support for TestEnvironment
arc/connection.py: fix doc
linuxdistro: add API level support for server side LinuxDistro objects
docs/source/conf.py: shows doc for both the class and the __init__ method
arc/cli/app.py: be less verbose on error messages to the user.

Pull requests still in review

Autotest

No open PRs for autotest this time

Virt Test

31 pull requests open, good review rate, probably need more attention, or we'll end up having another PR number explosion

https://github.com/autotest/virt-test/pulls

To restart or not to restart VMs compulsorily every virt-test?

Chris sent an RFC yesterday to the ML that could be summarized this way:

* In the early days of "kvm-autotest", one of the goals of the test framework was to save testing time as much as possible; * That is why we have things like the Environment, aexpect and the such - VMs should be up and running, unless a test configuration changed in a way that requires them to change.
 * The problem with this is two fold:
* The criteria of requiring restart has to do with VM state, rather than test params * The mapping VM state - test params is not exact, and sometimes will do the wrong thing * So after a bunch of back and forth discussion, we started to consider making VMs to always restart between tests. This will make most tests to run slower, but it won't depend of complicated and bug prone logic. * Another option is to improve qemu_devices in a way that it will make mapping params -> internal state in a way reliable enough to compare them to know if the vm will need restart.
 * Let's talk about that.

Reports

Virt Test Report 2013-12-05-00.02.13

Test suite version: Virt Test '2013.12.02-47-g20d9', Branch 'report', SHA1 '20d90c2da2b28e94f5e8db09c5ee55b4ea1c6c1b'

Success rate: 100.00 %
Tests passed: 10
Tests failed: 0
Tests skipped: 0
Total elapsed time: 267.64 s

Test Result Time Reason type_specific.migrate.default.tcp PASS 36.63 s Test completed successfuly type_specific.migrate.default.unix PASS 27.16 s Test completed successfuly type_specific.migrate.default.exec.default_exec PASS 27.10 s Test completed successfuly type_specific.migrate.default.exec.gzip_exec PASS 29.12 s Test completed successfuly type_specific.migrate.default.fd PASS 27.15 s Test completed successfuly type_specific.migrate.with_set_speed.tcp PASS 23.26 s Test completed successfuly type_specific.migrate.with_set_speed.unix PASS 23.25 s Test completed successfuly type_specific.migrate.with_set_speed.exec.default_exec PASS 23.00 s Test completed successfuly type_specific.migrate.with_set_speed.exec.gzip_exec PASS 27.13 s Test completed successfuly type_specific.migrate.with_set_speed.fd PASS 23.14 s Test completed successfuly


Virt Test Report 2013-12-04-23.56.25

Test suite version: Virt Test '2013.12.02-47-g20d9', Branch 'report', SHA1 '20d90c2da2b28e94f5e8db09c5ee55b4ea1c6c1b'

Success rate: 19.51 %
Tests passed: 16
Tests failed: 66
Tests skipped: 0
Total elapsed time: 38.27 s

Test Result Time Reason unattended_install.import.import.default_install.aio_native PASS 7.85 s Test completed successfuly unattended_install.import.import.default_install.aio_native ERROR 7.85 s CmdError: Command </usr/bin/virt-install type_specific.virsh.attach_detach_disk.attach_disk.normal_test.host_block_vm_name PASS 0.39 s Test completed successfuly type_specific.virsh.attach_detach_disk.attach_disk.normal_test.host_block_vm_name FAIL 0.39 s TestFail: dumpxml virt-tests-vm1 failed. type_specific.virsh.attach_detach_disk.detach_disk.error_test.invalid_option_1 PASS 0.40 s Test completed successfuly type_specific.virsh.attach_detach_disk.detach_disk.error_test.invalid_option_1 FAIL 0.40 s TestFail: dumpxml virt-tests-vm1 failed. type_specific.virsh.autostart.negative_test.invalid_option PASS 0.33 s Test completed successfuly type_specific.virsh.autostart.negative_test.invalid_option FAIL 0.33 s TestFail: dumpxml virt-tests-vm1 failed.


Libvirt updates

Chris won't attend today's meeting (it's too early in the US right now), so we won't have the usual updates.

Questions Corner

TODO

lmr

* Finish to implement a preliminary version of the split virt-test repo
* Take suggestion by Lukas: 'Add option to cleanup/not cleanup virt-test enviroment(?) after running a test (for debugging). The default is to cleanup at the end of the tests.

cevich
*  100% commited to https://github.com/autotest/virt-test/issues/1058

https://github.com/autotest/virt-test/pull/978

cleber
* Do a couple more package reviews to finish the fedora sponsorship thing
   - https://bugzilla.redhat.com/show_bug.cgi?id=985967
* Work on arc + virt-test-job (for makefile target consumption)
* Push installer + component isolation (pending bits) work upstream

jzupka
* pull request work
* fix bugs
* finishing glusterfs
* take some vacation

rmoura
* ARC code contributions
* PR review

ldoktor
* Until the end of the year working only 2-3 days per week
* pci_devices little modification (+ major cfg rework :D)
* fix my bugs
* retesting new virtio_console win drivers
* review
* Christmas vacation since ~19th Dec until the end of the year

kvm-qe (BJ):
Will try to clean up patches from us every month, and push more people review patch in upstream.
fyang: dedevice assignment cases
xutian: timer device
yuzheng: bug fix for some nic device tests
ypu: whql test scritps and bug fix
xwei, coli, xhan. scui: working for some cfg update and bug fix

_______________________________________________
Virt-test-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/virt-test-devel

Reply via email to