On 03/14/2014 02:37 AM, Xiaoqing Wei wrote:
On 03/14/2014 08:00 AM, Lucas Meneghel Rodrigues wrote:
Hi guys, I'm writing this because I wanted some input from users of
our test suite. From time to time, we have people arguing over some
change in the default behavior, and it's frequently difficult to have
a well informed decision on how the changes affect users.
Cases in point:
1) Always keep screendumps
https://github.com/autotest/virt-test/pull/1497
Keep screendumps by default. Xu argues that keeping the dumps is
useful to notice video bugs, which I agree. The downsides I see:
* You actually need someone looking into the dumps to make those bugs
discoverable, I suspect the majority of users won't look at those anyway.
The rule for KVM-QE on analyze autotest log, screendump is one of the
important log MUST to check.
esp.
1) when a Win VM BSOD, you cant know the MS bug check id by viewing the
screen.
2) when autotest cant ssh into guest, need to see screeen to know
whether VM fully booted(esp Win, didn't output its booting via serial)
* If the above sentence is true, we'd be spending a lot of disk space,
and while I agree with the general assessment that storage is cheap,
in practice we may be running in systems short on disk space and this
change would mean that disks fill up faster by default, specially in
long tests such as windows install. For someone like Paolo, that runs
a lot of windows installs, I imagine the extra disk consumption will
be significant.
Not a lot of disk space:
A Windows 2008 VM installation (finish it's installation approx 30 min),
consuming 8.0M on my test, on RHEL.6.5 host(I think that wont cost
double on other host...)
generally speaking, a tower machine would equipped hundreds (or even
thousands )of GB, 8.0M is the amount we treat it as tiny.
QE Acceptance test for qemu-kvm would run 150+ cases, including 10+ VM
installation, and the total log size is about 200M~400M each round(if
not qemu core dump during test)
Keeping as more logs as possible are important, you wont know when bugs
appear, if you suspect a video bug inside a test, but you didn't save
the screendumps, you got to reproduce, time is more important compare to
the disk spaces. and bugs might not 100% reproducible, you suspect, you
might need ten times of reproduce attempt.
Yes, fair enough. Let's do this :)
_______________________________________________
Virt-test-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/virt-test-devel
