On 03/14/2014 09:36 AM, Paolo Bonzini wrote:
Il 14/03/2014 01:00, Lucas Meneghel Rodrigues ha scritto:
Hi guys, I'm writing this because I wanted some input from users of our
test suite. From time to time, we have people arguing over some change
in the default behavior, and it's frequently difficult to have a well
informed decision on how the changes affect users.
Cases in point:
1) Always keep screendumps
https://github.com/autotest/virt-test/pull/1497
Keep screendumps by default. Xu argues that keeping the dumps is useful
to notice video bugs, which I agree. The downsides I see:
* You actually need someone looking into the dumps to make those bugs
discoverable, I suspect the majority of users won't look at those anyway.
* If the above sentence is true, we'd be spending a lot of disk space,
and while I agree with the general assessment that storage is cheap, in
practice we may be running in systems short on disk space and this
change would mean that disks fill up faster by default, specially in
long tests such as windows install. For someone like Paolo, that runs a
lot of windows installs, I imagine the extra disk consumption will be
significant.
No, I actually don't care. I prefer looking at screendumps than video.
2) Save screendump per VM pid rather then name
https://github.com/autotest/virt-test/pull/1491
Feng Yang argues that with the current schema we end up merging
screenshots from vms that may be different in configuration. To me, the
problem lies in the fact that different qemu instances don't imply in
different vms in a broader sense, they might just be different boots of
the same vm. Anyway, the direct impact of the patch is that by having
dir logs per PID we have more video files, that will take up some
additional encoding time (in my machine, extra 4 seconds per extra video
encoded). This adds up to 3 minutes in my default run, increasing it
from 12 minutes to 15 minutes (25% increase).
So that's what I wanted to share. Let me know if you have any comments.
I agree with this too. Perhaps make video encoding optional given the
above change to keep screendumps by default?
I find the videos to be very very useful, and not demanding in space, so
it's a personal preference of mine that we keep generating both.
_______________________________________________
Virt-test-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/virt-test-devel
