On 03/20/2014 07:28 AM, Ming Lei wrote:
This shouldn't be necessary. It happened due to the config bug I fixed
some minutes ago.
So NACK this one.
Signed-off-by: Ming Lei <[email protected]>
---
virttest/lvm.py | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/virttest/lvm.py b/virttest/lvm.py
index 5aff340..56bbbee 100644
--- a/virttest/lvm.py
+++ b/virttest/lvm.py
@@ -475,7 +475,7 @@ class LVM(object):
return vol
return None
- def setup_pv(self, vg):
+ def setup_pv(self, vg, vg_name):
"""
Create a physical volume devices;
@@ -484,7 +484,7 @@ class LVM(object):
:return: list of PhysicalVolume object;
"""
pvs = []
- cmd = "lvm pvs -opv_name,pv_size %s %s" % (COMMON_OPTS, vg.name)
+ cmd = "lvm pvs -opv_name,pv_size %s %s" % (COMMON_OPTS, vg_name)
output = utils.system_output(cmd)
for line in output.splitlines():
pv_name, pv_size = line.split()
@@ -520,7 +520,7 @@ class LVM(object):
vg_name = self.params["vg_name"]
vg = self.get_vol(vg_name, "vgs")
if vg is None:
- pvs = self.setup_pv(vg)
+ pvs = self.setup_pv(vg, vg_name)
vg = VolumeGroup(vg_name, 0, pvs)
vg.create()
self.register(vg)
@@ -530,7 +530,7 @@ class LVM(object):
pv_name = self.params.get("pv_name")
if pv_name:
# if set pv_name then add pvs into volume group
- pvs = self.setup_pv(vg)
+ pvs = self.setup_pv(vg, vg_name)
for pv in pvs:
vg.extend_pv(pv)
vg.append_lv(lv)
@@ -642,7 +642,7 @@ class EmulatedLVM(LVM):
self.params["pv_name"] = pv_name.strip()
return pv_name
- def setup_pv(self, vg):
+ def setup_pv(self, vg, vg_name=None):
"""
Setup physical volume device if exists return it directly;
"""
_______________________________________________
Virt-test-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/virt-test-devel
