On Wed, 11 Apr 2018 12:58:37 +0200
Halil Pasic <[email protected]> wrote:
> On 04/11/2018 04:19 AM, Stefan Hajnoczi wrote:
> > On Wed, Apr 11, 2018 at 12:11:25AM +0200, Halil Pasic wrote:
> >> \begin{lstlisting}
> >> -virtq_disable_interrupts(vq);
> >> +virtq_disable_notifications(vq);
> >
> > This name is ambiguous. Only used buffer notifications are disabled,
> > not configuration change notifications.
> >
>
> One could argue that the only virtqueue scoped notification received
> by the driver are used buffer notifications. That's why I thought
> this would be sufficient (btw. if it's ambiguous it was ambiguous before
> too as both options are called interrupts).
>
> But the more straight-forward the better.
Agreed.
>
> > How about:
> >
> > virtq_disable_used_buffer_notifications(vq);
> >
>
> In absence of further discussion I will take this for the next
> version.
Sounds good to me.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
