You write "both are configured", "try to configure both", "disable one and switch to other" "mixed mode" etc..
But no modes/levels are mentioned in the patch, not once. I totally agree that *if* we define 2 modes, we should have strict rules on how to switch between modes and how to operate with both modes. But if we decide to have modes, your suggestion is not enough IMO, we should explicitly define the modes. In my POV, we should have no modes at all, everything is per queue, and VIRTIO_NET_CTRL_NOTF_COAL_RX_SET is exactly the same as iterating through the RX queues and issuing a VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET command. Every queue will use the last coalescing parameters it received from the driver, regardless to the command used to deliver the parameters. No modes at all. I really don't see what we gain from having different operation modes. I thought that we agreed not to have operation modes in v1. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
