Andi Kleen wrote:
> Basic idea looks good.
>
> But is the 5 argument support really needed? I don't see any paravirt
> ops functions that needs it and even if there was one it still wouldn't be
> clear
> if it made sense to export it.
64-bit args are passed as a pair of 32-bit args, so PAE set_pte_at*
functions end up with 5 args. They're used often, so they may be worth
patching, but I'm not sure if they're worth exporting. They are
implicitly exported in a non-PARAVIRT build by the fact that they're
inline functions/macros in a header. I don't know if any modules
actually use them.
J
_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/virtualization
