On Fri, 2007-04-20 at 14:36 -0700, Zachary Amsden wrote: > Jeremy Fitzhardinge wrote: > > Zachary Amsden wrote: > > > >> Yes, I don't know either - but we should be consistent about their > >> export regardless of whether PAE is selected or not. So we should > >> either have 5 arg macros or not export set_pte_at* at all, even in 4 > >> arg version. > >> > > > > So can you separately control exportability independently from patchability? > > > > Nope. But I think we should maintain parity between PAE and non-PAE - > and probably also maintain parity between non-paravirt-ops and > paravirt-ops, which means the 5 arg macros are a good idea. It's not > like they are very hard to create or maintain.
Less exports good. Consistency with all config options isn't a hard requirement: I'd be tempted not to export the pte functions. Rusty. _______________________________________________ Virtualization mailing list [email protected] https://lists.linux-foundation.org/mailman/listinfo/virtualization
