On Wed, 08 Aug 2007 20:32:15 -0400 Steven Rostedt <[EMAIL PROTECTED]> wrote: > > diff --git a/drivers/lguest/i386/lg.h b/drivers/lguest/i386/lg.h > index 64f0abe..c5ea14c 100644 > --- a/drivers/lguest/i386/lg.h > +++ b/drivers/lguest/i386/lg.h > @@ -20,6 +20,8 @@ > #include <linux/err.h> > #include <asm/semaphore.h> > #include "irq_vectors.h" > +/* some files include this, some include the parent */ > +#include "../lg.h"
Surely everything should just include the parent which allows for easier consolidation over time. (as you are doing here) > --- a/drivers/lguest/lg.h > +++ b/drivers/lguest/lg.h > @@ -1,3 +1,19 @@ > +#ifndef _LGUEST_LG_GENERIC > +#define _LGUEST_LG_GENERIC Maybe _LGUEST_LG_H? and the arch ones could use _LGUEST_I386_LG_H etc. -- Cheers, Stephen Rothwell [EMAIL PROTECTED] http://www.canb.auug.org.au/~sfr/
pgplcijugdsFi.pgp
Description: PGP signature
_______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/virtualization
