> -----Original Message-----
> From: Christoph Hellwig [mailto:[email protected]]
> Sent: Monday, June 06, 2011 7:15 PM
> To: KY Srinivasan
> Cc: [email protected]; [email protected];
> [email protected]; [email protected]; Haiyang Zhang;
> Abhishek Kane (Mindtree Consulting PVT LTD)
> Subject: Re: [PATCH 24/49] Staging: hv: vmbus: Get rid of the unused wrapper -
> vmbus_onchannel_event()
> 
> On Mon, Jun 06, 2011 at 03:49:48PM -0700, K. Y. Srinivasan wrote:
> > Now, get rid of the unused wrapper - vmbus_onchannel_event().
> 
> I'd merge this into the previous patch.  In general your patch split
> seem a little too fine grained to me in general.  When you remove a
> wrapper you can inline it into the callsite directly, if you clean up a
> function directly inlining it into the helper is fine, etc.
> 
I agree with you that some of these patches are too fine grained; but 
I thought that was what was expected - "one change per patch".

Regards,

K. Y
_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/virtualization

Reply via email to