On Sat, Jul 16, 2011 at 04:01:39PM +0300, Sasha Levin wrote: > Is think that what Christoph meant was simplifying it to: > > if (dev_is_ide) > storvsc_get_ide_info(device, &target, &path); > > host_dev->path = device_info.path_id; > host_dev->target = device_info.target_id;
Indeed. In addition path is unused and target is only used in the second dev_is_ide conditional, so both the call and the target and path variables can be moved into that one to further simplify the function. But I'm fine with delaying that cleanup to a follow on patch so that we can make progress in getting this pile merged. _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/virtualization
