SIGIO should be sent when a port gets unplugged. However, the SIGIO is sent only when there's a userspace application that has the port opened, and has asked for SIGIO to be delivered. We were clearing out guest_connected before calling send_sigio_to_port(), resulting in a sigio not getting sent to users.
Fix by setting guest_connected to false after invoking the sigio function. Signed-off-by: Amit Shah <[email protected]> --- drivers/char/virtio_console.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c index 1d4b748..ce71df1 100644 --- a/drivers/char/virtio_console.c +++ b/drivers/char/virtio_console.c @@ -1542,12 +1542,14 @@ static void unplug_port(struct port *port) spin_unlock_irq(&port->portdev->ports_lock); if (port->guest_connected) { - port->guest_connected = false; port->host_connected = false; wake_up_interruptible(&port->waitqueue); /* Let the app know the port is going down. */ send_sigio_to_port(port); + + /* Do this last so that sigio is actually sent */ + port->guest_connected = false; } if (is_console_port(port)) { -- 1.8.1.4 _______________________________________________ Virtualization mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/virtualization
