RE: [PATCH 1/2] vdpa: Add support for querying statistics

[Parav Pandit via Virtualization]

> From: Eli Cohen <e...@nvidia.com>
> Sent: Monday, November 22, 2021 8:37 PM
> 
> On Mon, Nov 22, 2021 at 12:15:36PM +0200, Parav Pandit wrote:
> >
> >
> > > From: Jason Wang <jasow...@redhat.com>
> > > Sent: Monday, November 22, 2021 3:02 PM
> > >
> > > > If we go with vendor stats, how can we communicate the information
> > > > to userspace? Currenlty we use netlink attributes defined to pass
> > > > this information.
> > >
> > > It can be done exactly as what have been done in the patch, we can
> > > document it as vendor stats.
> > >
> > Yes, attribute to have VENDOR_ prefix in it.
> > >
> > > Ok, I think I get you. So I wonder if it's more useful to use device
> > > specific counters. For networking, it could be packets send/received etc.
> >
> > Yes, I equally discussed this previously with Eli as its more meaningful 
> > for end
> users.
> > We just return the device id of it along with queue number that helps to 
> > show
> tx and rx.
> > For ctrl q, it is just ctrl commands and ctrl completions.
> 
> I don't think we should mix send/receive packets for descriptors statistics. 
> The
> hardware could process a descriptor and still not transmit any packet.
> 
> We can add packets send/recv but descriptor statistics have their own value.
> 
Oh right. I read Jason's comment of _packets_ to fast. I meant to say 
send/receive descriptors.
I guess you already named them as tx and rx. Didn't review the patches in this 
series yet.

> To summarize, I can add the VENDOR_ preifx to the attibutes and re-send or is
> there anything else you think should change?
VENDOR_ prefix and command as iproute2 command as "vstats" looks fine to me.

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization