Charles Bailey [EMAIL PROTECTED] wrote:
> Charles Lane <[EMAIL PROTECTED]> wrote:
>>
>> Test 8 is more subtle...when you specify flags to the File::Glob:glob
>> function, it completely ignores its DEFAULT_FLAGS...in particular, you
>> lose the GLOB_NOCASE flag, that you *really* *need* on VMS.
> We could make a case for forcing GLOB_NOCASE always under VMS. It does remove
> one of the documented options, but since readdir will always return lower
> case filespecs, it's not useful, and it does create protability problems
> as with this test.
Well, I had something similar in an earlier glob-basic patch; it was
bounced by Sarathy because "GLOB_NOCASE" is already in $DEFAULT_FLAGS".
Perhaps File::Glob:: should have several sets of flags:
ALWAYS_ON_FLAGS
ALWAYS_OFF_FLAGS
DEFAULT_FLAGS
The question is: if you're going to override default behavior, do you
want the module to decide that you *really must have* this particular
flag? I'm not sure...
BTW, did you have a chance to look at the tainting of directories in
mg.c ? (message <[EMAIL PROTECTED]>)
The directory protection that triggers tainting seems wrong
to me ... to the extent that it would be a security hole...but
someone more familiar with tainting should take a look.
--
Drexel University \V --Chuck Lane
----------------->--------*------------<[EMAIL PROTECTED]
(215) 895-1545 / \ Particle Physics [EMAIL PROTECTED]
FAX: (215) 895-5934 /~~~~~~~~~~~ [EMAIL PROTECTED]
