On Tue, 31 Oct 2000, Charles Lane wrote:
> Peter Prymmer (<[EMAIL PROTECTED]> wrote:
> > On Sat, 28 Oct 2000, Charles Lane wrote:
>
> >> diff -uBb configure.com-orig configure.com
> >> --- configure.com-orig Fri Oct 27 23:50:54 2000
> >> +++ configure.com Fri Oct 27 23:36:47 2000
> >> @@ -677,6 +677,48 @@
> >> $ ENDIF
> >> $ DELETE/NOLOG/NOCONFIRM []ver.out;
> >> $ ENDIF
> >> +$!: check for perly/perly_c.vms generation
> >> +$ open/read fpy [-]perly.c
> >> +$ read fpy line
> >> +$ close fpy
>
> > Could you please use the idiom?:
>
> > $ open/read CONFIG [-]perly.c
> > $ read CONFIG line
> > $ close CONFIG
>
> > note that there is some cleanup code at the bottom of configure.com
> > that tries to determine if there are any remaining open files and
> > will C<$ close CONFIG> if it thinks that there are, but that code does
> > not know about c<$ close fpy>. Thanks.
>
> Will do.
Thank you. As long as you are willing to rewrite I'd like to pick another
tiny nit and request full lexical names so that the patch has:
s/f\$len\(/f\$length(/ and s/f\$file\(/f\$file_attributes(/
if that is not too much trouble (it's not a biggy if you've already
prepared a new patch though).
> >> +$ match = "/* postprocessed by vms_yfix.pl"
> >> +$ if f$extract(0,f$len(match),line) .nes. match
> >> +$ then
> >> +$ torig = f$cvtime(f$file("[-]perly.c","CDT"))
> >> +$ tvms = f$cvtime(f$file("[-.vms]perly_c.vms","CDT"))
> >> +$ if (torig .ges. tvms)
> >> +$ then
> >> +$ type sys$input:
> >> +$ deck
> >> +
> >> +Uh oh, looks like vms/perly_c.vms wasn't updated. That sometimes
> >> +happens with new Perl releases. If you have a working Perl already,
> >> +you can do the update yourself with:
> >> +
> >> + $ PERL vms/vms_yfix.pl
> >> +
> >> +after this procedure, but *before* running MMS/K. Please let the Perl
> >> +maintainers know so that this can be avoided in subsequent releases.
>
> > I pity the poor user who does not have perl previously installed on VMS
> > and receives this message ("Do you mean I have to have Perl installed
> > in order to install Perl?")
>
> Well, what else can we tell them? Maybe we should emphasize that it's
> in fact a bug in the distribution, much like having files missing.
>
> My main hope is that by having a flood of "hey, update vms/perly_c.vms!"
> messages right after a new release, the Pumpkings will modify their
> makefile to automatically do the updated as needed. Or at least raise
> the awareness level so that updates are less likely to be forgotten.
I was merely commenting. I don't think that the message needs a re-write.
I must admit that I am confused that the 7483 kit came out without having
running the vms yfixer since I had raised the objection that it had not
been run in the previous kit from Jarkko and he added two entries to the
change log: 1) said that he in fact ran the fixer script and 2) said that
he has now added a run of the vms specific script to the "regen_all"
target for the unix Makefile.SH (which turns into the Makefile on unix).
Peter Prymmer
