On Sun, 11 Feb 2001, Craig A. Berry wrote:

> Yes, and as you surmise, I think it's one of the Schwern patches 
> where this restriction is lifted.  Apparently anything following 'ok' 
> and the test number is now allowed.

This is a serious mistake.  Restricting what gets called ok adds rigor and
prevents error messages from fouling up testing.  Removing the restriction
can open a flood gate of false ok results.

> Perhaps, though I think I might rather hack the tests to perform one 
> integral print and get everything on one line.  It's not that '-' has 
> been added to '#' in the list of allowable things, but, if I read the 
> original p5p post correctly ("The restriction on what is allowed to 
> follow 'ok' has been dropped."), all restrictions for comments on the 
> same line as the 'ok' have been removed.  Bad idea, as you indicate. 
> If this stands we may have to tinker with test.com -- it's not clear 
> to me at first blush how much.

We should not have to tinker with test.com since perl's regression tests
should be restrictive enough to only allow a narrow definition of an ok
test.  If we let '-' through what's next? '%RMS-E-FILENOTFOUND' would that
string be ok too?

Peter Prymmer



Reply via email to