Brad,
It looks good and thanks. I noted that with 5.005_03 I obtained:
$ perl makefile.PL
Checking if your kit is complete...
Looks good
'POLLUTE' is not a known MakeMaker parameter name.
Writing Descrip.MMS for VMS::Lock
nevertheless the tests came out ok like so (VMS V7.1 DEC C 6.2):
t/basic.............
ok
t/deadlock..........
ok
t/value_block.......
ok
All tests successful.
Files=3, Tests=43, 11 wallclock secs ( 0.00 cusr + 0.00 csys = 0.00 CPU)
with similar results for perl 5.6.0 on VAX VMS 6.2, DECC 5.3.
I note that 5.6.0's MakeMaker seems to deal with POLLUTE OK, but that
5.005_03 did not. So how about a change like the following?
--- Makefile.PL;-1 Thu Mar 30 00:32:40 2000
+++ Makefile.PL Thu Mar 1 13:40:56 2001
@@ -1,11 +1,19 @@
use ExtUtils::MakeMaker;
# See lib/ExtUtils/MakeMaker.pm for details of how to influence
# the contents of the Makefile that is written.
-WriteMakefile(
+
+my %options = (
'NAME' => 'VMS::Lock',
'VERSION_FROM' => 'Lock.pm', # finds $VERSION
'LIBS' => [''], # e.g., '-lm'
'DEFINE' => '', # e.g., '-DHAVE_SOMETHING'
'INC' => '', # e.g., '-I/usr/include/other'
+ );
+
+if ($] >= 5.006) {
+ %options = (%options,
'POLLUTE' => 1, # namespace pollution for more modern Perls
-);
+ );
+}
+
+WriteMakefile(%options);
End of Patch.
Oh, and if you do decide to repackage, how about a README file? Thanks
;-)
Peter Prymmer
