On Sat, Mar 03, 2001 at 11:58:54PM -0600, Craig A. Berry wrote:
> >Of course, running manually meant I also had "PERL_ROOT" defined, so
> >Perl had no difficulty finding its libraries.  Damn.
> 
> Been there, done that.  I think it could also grab modules from the
> library path of your installed Perl in this situation.

That's what was breaking the test in the first place (well, one of the
things).  It was trying to read modules out of the source dist (as
well as the installed dist!!)  Result: Every time you added a module
to lib/Pod/ the test would fail.  The list of modules in t/pod/find.t
was badly out of date when I found it.

Testing things which interact with their environment (such as
Pod::Find, or more seriously, File::Temp) requires having a known,
controlled environment which to test against.  Otherwise you don't
know if the code failed or the environment is just different than you
expected.

In short, tests shouldn't break because we added a new module to the
source.


> Moving higher in the directory tree and/or keeping find.t's private
> play space shallower seems preferable to changing the current
> directory.

How much shallower?  t/pod/sample_pods/Pod/Stuff.pm still too deep?
I'd really, really, really like to keep the test data for a particular
set of tests as close to the test itself as possible.  I'd also like
to keep them as segregated as possible.

So we've got effectively six levels to play with when the smoke
clears?  Two of the eight eaten up by /src/perl-current, (pardon the
Unixisms) or would it more typically be three leaving us five?


> Michael, are there other reasons your patch was withdrawn or are we
> the only ones causing you trouble?

No, there's a few other things.  I forgot a couple files and didn't
clean up find.t as well as I should have.  So you're not the only hold
up.


-- 

Michael G. Schwern   <[EMAIL PROTECTED]>    http://www.pobox.com/~schwern/
Actually I'm very sure we can resurrect people because we have that technology
already.  Cloning an entire sheep has already successfully been done by
Scottish scientists.  In the future, cloning will be allowed because
resurrection is promised in the Torah, and it is clearly the will of God.
             --Alex Chiu, Immortality Guy

Reply via email to