On Sun, Nov 25, 2001 at 04:20:45PM -0600, Craig A. Berry wrote:
> my_inet_aton() was accepting a zero-length host name and successfully 
> converting it to an address of all zeroes.  This is apparently not the 
> expected behavior since test #4 in lib/Net/t/config.t expressly uses a 
> zero-length string as an invalid hostname and the test was failing.  It 
> passes after the following patch.  Note that this only affects platforms 
> where HAS_INET_ATON is false.

Thanks, applied.
> --- ext/Socket/Socket.xs;-0     Thu Nov 15 17:25:48 2001
> +++ ext/Socket/Socket.xs        Sun Nov 25 15:58:00 2001
> @@ -87,7 +87,7 @@
>         unsigned int parts[4];
>         register unsigned int *pp = parts;
>  
> -       if (!cp)
> +       if (!cp || !*cp)
>                 return 0;
>         for (;;) {
>                 /*
> [end]

-- 
$jhi++; # http://www.iki.fi/jhi/
        # There is this special biologist word we use for 'stable'.
        # It is 'dead'. -- Jack Cohen

Reply via email to