At 11:35 AM +0200 4/23/02, Abigail wrote:
>Except for the END blocks, all of the other things were already fixed.
OK. The fixes were discussed over the last few days but weren't in Monday's
snapshot (perl@16083) so I assumed they had fallen by the wayside. I
still see no indication in the repository browser that the issues my
patch addresses are already fixed, but I could be missing something.
>I am confused about your change in the END blocks, you changed:
>
> END {unlink_all $datafile}
>
>to
>
> END {1 while unlink $datafile}
>
>The unlink_all function does a '1 while unlink $datafile', and it will
>print an error message if the file couldn't be removed. What is the
>benefit of not using 'unlink_all'?
Yes, that was a strange one. I was getting uninitialized value
warnings when the END blocks executed even though $datafile, for
example, clearly had something in it. I took the easy way out and
got rid of the function call since it didn't seem to add value there.
>Will this patch do?
>
>--- t/japh/abigail.t.orig Tue Apr 23 11:28:00 2002
>+++ t/japh/abigail.t Tue Apr 23 11:32:34 2002
Excellent, thanks!
--
________________________________________
Craig A. Berry
mailto:[EMAIL PROTECTED]
"... getting out of a sonnet is much more
difficult than getting in."
Brad Leithauser
