On Tue, Jun 10, 2003 at 04:58:52PM -0500, Craig Berry wrote:
> I'm not seeing the hangs that Peter is seeing, but I do see one MakeMaker failure in 
> [EMAIL PROTECTED] on OpenVMS Alpha 7.2-1:
> 
> $ perl [-.lib.extutils.t]command.t      
> 1..27
> ok 1 - use ExtUtils::Command;
> not ok 2 - found one file
> #     Failed test ([-.lib.extutils.t]command.t at line 54)
> #          got: '2'
> #     expected: '1'
> 
> There are two files because the t/ directory has a file called 'base' and also a 
> directory called 'base' (or, on VMS 'base.DIR').  If I understand how the test is 
> working, it seems a bit vulnerable to whatever happens to be first in the alphabet 
> in the test directory.  If another test, for example, created aatmp.1 and aatmp.2 
> and failed to clean them up, these would both get picked up in the wildcard 
> expansion.

Try this:

--- Command.t   25 Mar 2003 10:28:34 -0000      1.10
+++ Command.t   11 Jun 2003 04:46:55 -0000
@@ -31,11 +31,14 @@
 }
 
 {
-    # get a file in the current directory, replace last char with wildcard 
+    # get a file in the MM test directory, replace last char with wildcard 
     my $file;
     {
         local *DIR;
-        opendir(DIR, File::Spec->curdir());
+        my $mmtestdir = $ENV{PERL_CORE}
+          ? File::Spec->catdir(File::Spec->updir, 'lib', 'ExtUtils', 't')
+          : File::Spec->curdir;
+        opendir(DIR, $mmtestdir);
         while ($file = readdir(DIR)) {
             $file =~ s/\.\z// if $^O eq 'VMS';
             last if $file =~ /^\w/;


-- 
You're smoother than a tunnel of shining sorrow.

Reply via email to