Craig Berry wrote:

!+++ lib/Net/Ping.pm           Mon Jul 21 19:15:42 2003
!@@ -316,9 +316,9 @@
!                         # set the non-blocking mode (set O_NONBLOCK)
!
!   my $flags;
!-  if ($^O eq 'MSWin32') {
!-      # FIONBIO enables non-blocking sockets on windows.
!-      # FIONBIO is (0x80000000|(4<<16)|(ord('f')<<8)|126), as per
winsock.h.
!+  if ($^O eq 'MSWin32' || $^O eq 'VMS') {
!+      # FIONBIO enables non-blocking sockets on windows and vms.
!+      # FIONBIO is (0x80000000|(4<<16)|(ord('f')<<8)|126), as per
winsock.h, ioctl.h
!       my $f = 0x8004667e;
!       my $v = pack("L", $block ? 0 : 1);
!       ioctl($fh, $f, $v) or croak("ioctl failed: $!");

No that does not seem to work for me.  Unfortunately I still
see this:

$ perl lib/Net/Ping/t/190_alarm.t
1..6
# Running under perl version 5.008001 for VMS
# Current time local: Tue Jul 22 11:20:11 2003
# Current time GMT:   Tue Jul 22 15:20:11 2003
# Using Test.pm version 1.23
ok 1
ok 2
ok 3
ok 4
ok 5
not ok 6
# Failed test 6 in lib/net/ping/t/190_alarm.t at line 52
#  lib/net/ping/t/190_alarm.t line 52 is: ok $@ =~ /alarm works/ or die $@;
fcntl F_GETFL: invalid argument at lib/net/ping/t/190_alarm.t line 43
%SYSTEM-F-ABORT, abort

By the way I think I was misleading yesterday when I said that the
two lib/Net/Ping test failures looked the same.  With your patch
to lib/Net/Ping in place the 450_service.t test does not look
any different from it not in place and it looks like this:

$ perl lib/Net/Ping/t/450_service.t
1..26
# Running under perl version 5.008001 for VMS
# Current time local: Tue Jul 22 11:22:21 2003
# Current time GMT:   Tue Jul 22 15:22:21 2003
# Using Test.pm version 1.23
ok 1
ok 2
ok 3
ok 4
ok 5
ok 6
ok 7
Can't locate object method "service_check" via package "Net::Ping" at
lib/net/ping/t/450_service.t line 71.
%SYSTEM-F-ABORT, abort

Which does look like a problem in [.lib.Net]Ping.pm itself.

Peter Prymmer

Reply via email to