On Thu, Jul 14, 2005 at 05:38:53PM -0400, John E. Malmberg wrote: > I have not tested this or anything on 5.8.7, I am in the process of > moving my changes over to 5.8.7. > > I have seen no changes in 5.8.7 from the files I started with on my > 5.8.6 basis.
ExtUtils::MakeMaker is available as a separate CPAN module. Please patch against that as it is more up to date and easier to figure out if the bug is in Perl or MakeMaker. The up-to-the-moment version is available from http://svn.schwern.org/svn/CPAN/ExtUtils-MakeMaker/trunk > These changes should be at most harmless until the rest of the VMS Perl > catches up with them, or at worse, Perl really does not function well if > you put the CRTL in the UNIX modes now. Before I even jump into this code I have to protest at the size of it. I've spent years whittling down and encapsulating all the special cases in MakeMaker, particularly for VMS, and now this adds a ton. I think part of the problem is the repetition. I see this sort of thing repeated a lot. > +if ($Is_VMS) { > + my $unix_report; > + my $unix_only; > + > + $unix_report = $ENV{'DECC$FILENAME_UNIX_REPORT'}; > + if (defined $unix_report) { > + if (($unix_report lt '1') && ($unix_report ne 'ENABLE')) { > + $unix_report = undef; > + } > + } > + $unix_only = $ENV{'DECC$FILENAME_UNIX_ONLY'}; > + if (defined $unix_only) { > + if (($unix_only lt '1') && ($unix_only ne 'ENABLE')) { > + $unix_only = undef; > + } > + } > + $unix_report = 1 if (defined $unix_only); Not only in this patch but in many of the other patches you've submitted. I think step one of your porting effort should be to encapsulate this "what sort of VMS am I on?" logic into a module. Perhaps something as simple as a bunch of new File::Spec::VMS methods. So I'd recommend you halt your porting and focus on encapsulating the differences between your VMS environment and the traditional one. I doubt your patches will be accepted in their current state and I'd hate to see all that effort wasted. -- Michael G Schwern [EMAIL PROTECTED] http://www.pobox.com/~schwern You are wicked and wrong to have broken inside and peeked at the implementation and then relied upon it. -- tchrist in <[EMAIL PROTECTED]>
