Craig A. Berry wrote:
At 5:48 PM -0400 7/24/05, John E. Malmberg wrote:


              if (UNLINK(s))
....................^
%CC-W-NOTCONSTQUAL, In this statement, the

And this should take care of it. Accidentally left out of my patch of two hours 
ago.
--- doio.c_orig Sat Jul 23 18:54:47 2005
+++ doio.c      Sat Jul 23 18:54:48 2005
@@ -1835,14 +1835,14 @@
            s = SvPV_nolen_const(*mark);
            APPLY_TAINT_PROPER();
            if (PL_euid || PL_unsafe) {
-               if (UNLINK(s))
+               if (UNLINK((char *)s))

Please do not do that, you are possibly introducing either a silent data corrupter or an intermittent access violation. Both of which may be hard to diagnose.

I would strongly recommend the patch that I posted before I received this.

The const modifier needs to be put on the unlink() wrappers, and the prototypes that reference it.

The const modifier is also an important part of compiler optimization and lint features.

-John
[EMAIL PROTECTED]
Personal Opinion Only

Reply via email to