At 6:13 PM -0800 1/19/06, chromatic wrote:
>On Thursday 19 January 2006 14:28, Craig A. Berry wrote:
>
>> On VMS, I don't think the
>> permissions on the source of a copy have anything to do with the
>> resulting permissions on the target. If they do, they're way down
>> the list after process defaults, the permissions on the directory
>> into which we're copying, permissions on lower versions of the same
>> file, access control lists, etc.
>
>Seems like a skip is in order, then:
>
> SKIP:
> {
> skip( 'permissions not copied on VMS', 2 ) if $Is_VMS;
>
> is( -w $copy, -w $orig, " writable if original was" );
> is( -x $copy, -x $orig, " executable if original was" );
> }
What I ended up doing is changing the test to do what it says it's
doing, that is, only checking permissions of interest on the target
of the copy if they were there on the source of the copy. The
following is in blead as #26919:
--- lib/ExtUtils/t/Manifest.t;-0 Thu Nov 10 11:29:20 2005
+++ lib/ExtUtils/t/Manifest.t Sat Jan 21 10:06:08 2006
@@ -150,8 +150,16 @@ is_deeply( [sort map { lc } @copies], [s
foreach my $orig (@copies) {
my $copy = "copy/$orig";
ok( -r $copy, "$copy: must be readable" );
- is( -w $copy, -w $orig, " writable if original was" );
- is( -x $copy, -x $orig, " executable if original was" );
+
+ SKIP: {
+ skip " original was not writable", 1 unless -w $orig;
+ ok(-w $copy, " writable if original was" );
+ }
+
+ SKIP: {
+ skip " original was not executable", 1 unless -x $orig;
+ ok(-x $copy, " executable if original was" );
+ }
}
rmtree('copy');
[end]
--
________________________________________
Craig A. Berry
mailto:[EMAIL PROTECTED]
"... getting out of a sonnet is much more
difficult than getting in."
Brad Leithauser
