Craig A. Berry wrote:
At 12:43 PM -0400 4/2/06, John E. Malmberg wrote:
Craig A. Berry wrote:
I finally got around to testing this, and there are a few problems with it.
2.) The code as written does not handle a null second argument to
utime() and accvios if it gets one. Null is valid (and quite common
because it means "use the current time") and needs to be handled.
I missed that. Apparently while common, it is not tested in the Perl self
tests.
It is tested in [.t.io]fs.t. But since we were never using the new
code unless DECC$EFS_CHARSET was defined, I hadn't seen the
failure.
I missed that, at this point I have been mainly testing to make sure I
did not break the default behavior.
3.) I can't think of any relationship between DECC$EFS_CHARSET and
utime. Perhaps this was supposed to be DECC$EFS_FILE_TIMESTAMPS ?
Even here, though, I don't think we need to do anything differently
because the CRTL utime() is going to do its own feature checking.
The ACP interface that is used for the work around to not having a
built in utime() can not handle EFS file specifications. It needs to
have the on-disk file specification.
But won't do_rmsexpand() take care of that?
Yes, but then you do not pick up setting the DECC$EFS_FILE_TIMESTAMPS
values. Using the CRTL utime() picks up both.
I am currently testing a merge the ODS-2 RMSEXPAND with the 0DS-5
version through macros.
-John
[EMAIL PROTECTED]
Personal Opinion Only
