demerphq wrote:
> On 4/10/07, Rafael Garcia-Suarez <[EMAIL PROTECTED]> wrote:
>> On 10/04/07, Jos I. Boumans <[EMAIL PROTECTED]> wrote:
>> > > The first files come from output_handle(), as far as I can tell;
>> isn't
>> > > there a way to delete them on close or at exit ?
>> >
>> > There is, cpanplus' Makefile.PL has a 'make clean' target that cleans
>> > all
>> > these up... but I'm not sure if/how we can call this from the test
>> > suite,
>> > or as part of perl's 'make clean'...
>> >
>> > > The dummy-cpanplus/* ones should maybe be cleared by a 99_cleanup.t
>> > > test ?
>> >
>> > They're all cleared by 'make clean' :)
>>
>> I can add them to bleadperl's make clean, but the problem is the
>> filename portability. Do we have .[0-9][0-9]_CPANPLUS files on all
>> platforms ? I'd rather have the information about the form of those
>> files in only one place. (The problem with removing the directory
>> dummy-cpanplus is less bothersome)
>>
>
> Attached patch is required to get CPANPLUS to do the right thing when
> being built as part of the core. The problem appears to be related to
> the code in ExtUtils::MakeMaker that does autodetection of the perl
> location when building on an uninstalled perl. It only checks up to 5
> directories above the current one, however Jos'es latests tests do
> stuff at 7 levels deep. Which means it doesnt realize its running on
> an uninstalled perl.
This is unlikely to work on most VMS filesystems which only allow 8 levels of
total depth. 1 for the perl source directory, assuming its been made into its
own root, 3 for lib/CPANPLUS/t then 7 more for the tests and you're at 11.
> With this patch applied (and the permission issues sorted out in
> smoking) I get only a single failure from CPANPLUS on win32:
>
> ../lib/CPANPLUS/t/20_CPANPLUS-Dist-MM....NOK 79/0
> # Failed test ' $dist->prepare failed'
> # at ../lib/CPANPLUS/t/20_CPANPLUS-Dist-MM.t line 364.
> # Looks like you failed 1 test of 81.
> ../lib/CPANPLUS/t/20_CPANPLUS-Dist-MM....dubious
> Test returned status 1 (wstat 256, 0x100)
> DIED. FAILED test 79
>
> I havent investigated this failure yet and probably wont do so today
> at all due to lack of tuits.
>
> Note that this patch does NOT bump the version of any modules.
>
> HTH
> Yves
>
>
>
>
> ------------------------------------------------------------------------
>
> Index: lib/ExtUtils/MM_Unix.pm
> ===================================================================
> --- lib/ExtUtils/MM_Unix.pm (revision 1485)
> +++ lib/ExtUtils/MM_Unix.pm (working copy)
> @@ -1574,12 +1574,9 @@
>
> unless ($self->{PERL_SRC}){
> my($dir);
> - foreach $dir ($Updir,
> - $self->catdir($Updir,$Updir),
> - $self->catdir($Updir,$Updir,$Updir),
> - $self->catdir($Updir,$Updir,$Updir,$Updir),
> - $self->catdir($Updir,$Updir,$Updir,$Updir,$Updir))
> + foreach my $dir_count (1..8) # 8 is the VMS limit for nesting
> {
> + $dir = $self->catdir(($Updir) x $dir_count);
> if (
> -f $self->catfile($dir,"config_h.SH")
> &&
