Craig A. Berry wrote:
At 12:10 AM -0500 8/31/07, John E. Malmberg wrote:
This patch makes the following changes:
In lib/Archive/Tar.pm, currently Perl on VMS can not fully deal
with directory specifications that have C<.> characters in them.
>> Internally the VMS.C module currently translates them to C<_>
>> characters.
I'm not seeing any Archive::Tar failures in blead, so I'd like to
know a bit more about what this patch actually fixes before applying
it. Does it fix any of the CPANPLUS failures? Is it necessary when
building on ODS-2 but not ODS-5?
It along with the other fixes some of the CPANPLUS failures. The
following are now passing for me.
[-.lib.CPANPLUS.t]04_CPANPLUS-Module.t
[-.lib.CPANPLUS.T]07_CPANPLUS-Internals-Extract.t
I am currently trying to track down the failures in
21_CPANPLUS-Dist-No-Build.t
File::Spec on VMS can not currently handle the UNIX pathnames that
are showing up here, so use the UNIX routines and keep everything in
UNIX syntax. One of the failures is handling empty path elements.
In lib/Archive/Tar/t/02_methods.t, File::Spec->catfile was being
used where a directory path was needed. There is a significant difference
between catpath and catfile on VMS, and catpath must be used if the
result is intended to be a path.
But you replaced catfile with catdir, not catpath. In any case,
catfile looks right to me as it appears to be generating a file name,
not a directory name.
I meant to type catdir not catpath there.
BTW: Two of my posts that I cc: to you just bounced, but it appears that
you have responded to one of them.
-John
[EMAIL PROTECTED]
Personal Opinion Only
